-
Notifications
You must be signed in to change notification settings - Fork 202
feat(picker): refactoring template markup, testing token passthroughs #3792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
castastrophe
merged 19 commits into
spectrum-two
from
aramos-adobe/css1065-picker-markup-followup
Jun 5, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e519171
feat(picker-markup): add shirt size within template
aramos-adobe e5eaac5
feat(picker-markup): adjusting picker markup to higher level of template
aramos-adobe e98b3f6
chore(picker-markup): restore dropzone css file
aramos-adobe 868bd35
chore(picker-markup): adding lint line
aramos-adobe 4bd5de3
feat(picker-markup): remove duplicate icon template
aramos-adobe f9af168
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe da7dad2
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe 74f6939
feat(picker-markup): fixing is quiet layout bugs
aramos-adobe 0cd0d2d
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe 3ef143d
fix(picker-markup): remove duplicate border on WHCM
aramos-adobe fe9373b
feat(picker-markup): readjusting picker popover mod passthroughs
aramos-adobe 7c3e98c
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe 1065015
feat(picker): updating changeset, story, css
aramos-adobe e89ea7e
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe b2e0a3f
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe d6b8ee4
feat(picker): update template and changeset
aramos-adobe 1290085
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe 34697f8
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe 6f2e972
Merge branch 'spectrum-two' into aramos-adobe/css1065-picker-markup-f…
aramos-adobe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| "@spectrum-css/picker": major | ||
| --- | ||
|
|
||
| ### S2 Picker component refactor | ||
|
|
||
| - Refactors Picker component to use proper custom property naming conventions | ||
| - Adds size-specific animation distances for Popover component | ||
| - Improves component structure with proper class by renaming `spectrum-Picker` to `spectrum-Picker-button` | ||
| - `spectrum-Picker` now encapsulates help text, label, and popover components | ||
| - Adds `flex-shrink` to progress circle for better layout control when truncation and loading is visible | ||
| - Updates Popover animation distance to use `spectrum-Picker` custom properties | ||
|
|
||
| #### New token | ||
|
|
||
| `--spectrum-picker-popover-animation-distance` | ||
|
|
||
| #### Renamed tokens | ||
|
|
||
| `spectrum-picker-spacing-picker-to-popover` --> `--spectrum-picker-popover-animation-distance` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is on the
spectrum-twobranch. I'm not certain how we're handling the changesets, so this is just a question for and about the future. When we do finally mergespectrum-twointomain, do you know yet how we're going to handle this "major" change, AND the S2 picker migration "major" change? Are they going to get lumped together, and picker will get bumped only 1 version number, or are they going to be separated so that picker actually gets 2 version bumps?This isn't really a question related to your work, I agree that these are breaking changes. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marissahuysentruyt Can this be a patch? I'm not sure how it works but hopefully that doesn't bump the version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's small enough to be a patch, personally. Maybe Cassondra or Patrick have a preference? I mean....it's a breaking/major change from the last iteration of the picker. That picker however, isn't available to consumers though.
The changesets stuff trips me up a bunch. If it makes you feel better, when we broke the dialog migration up, I added 2 changesets both marked major. I had the same question then!! 😆
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can (and probably will) fuss with the changelog manually for this kind of release when the time comes, so I'm not worried about semver, per say. At this point, I am thinking about what impact changes might have on the SWC project. Would they require significant refactoring to support these changes? Then yeah, it probably is a major from that perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Such a great clarification and I so appreciate y'all asking it! Can we surface this in the team chat as well to make sure we're all in agreement?)