fix(S2): React 19 and storybook fixes #8359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
changed the title
|
Build successful! 🎉 |
devongovett
reviewed
Jun 6, 2025
| selectionMode: 'multiple' | ||
| selectionMode: 'multiple', | ||
| decorators: [ | ||
| (Story, {viewMode}) => <Story viewMode={viewMode} /> |
There was a problem hiding this comment.
Can you add this in the ActionBar example with CardView too? Looks like it's horizontally scrolling at the moment
There was a problem hiding this comment.
Looks like viewMode isn't actually making it into the story from the decorator, so I need to fix that first.
There was a problem hiding this comment.
I've been poking around locally, the viewMode doesn't seem to have been working for quite some time actually, regardless if you run the storybook in docs mode or not. Still bisecting
There was a problem hiding this comment.
Apparently something from #7435? Thats when viewMode becomes undefined for me locally but nothing in the PR jumps out to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inertvalue error (for React 19) in Skeleton and RAC Tabssrcstring error in Image✅ Pull Request Checklist:
📝 Test Instructions:
Check S2 CardView and ActionBar stories and verify they render without issues.
🧢 Your Project: