Skip to content

fix(focus): add permisison element to focusable elements list #8356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabrielchl
Copy link

@gabrielchl gabrielchl commented Jun 6, 2025

Closes #8226

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • change contain={contain} to contain at packages/@react-aria/focus/stories/FocusScope.stories.tsx:61
  • add <permission type="microphone"></permission> to packages/@react-aria/focus/stories/FocusScope.stories.tsx:66
  • in Chrome Beta, visit http://localhost:9003/?path=/story/focusscope--keyboard-navigation-no-contain and verify that the permission element can now be tabbed to and away from

🧢 Your Project:

before (when tab/shift-tab-ing, it skips over the permission element):
Untitled2

after (able to navigate to the permission element via keyboard, and activate the element):
Untitled1

@gabrielchl gabrielchl changed the title fix(focus): add permisison element to focusable elements list fix(focus): add permisison element to focusable elements list. Jun 6, 2025
@gabrielchl gabrielchl changed the title fix(focus): add permisison element to focusable elements list. fix(focus): add permisison element to focusable elements list Jun 6, 2025
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@reidbarber
Copy link
Member

reidbarber commented Jun 6, 2025

Looks like you'll need to Sign the CLA, then close and re-open this PR to trigger another build that passes.

@gabrielchl gabrielchl closed this Jun 6, 2025
@gabrielchl gabrielchl reopened this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

focusableElements selectors list doesn't include the new <permission /> element
2 participants