-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Tree multiple level loading support and only count "items" for collection size #8349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LFDanLu
wants to merge
20
commits into
main
Choose a base branch
from
multi_loader_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the top most collection
Build successful! 🎉 |
Build successful! 🎉 |
also the aria row index and pos in set from empty/isLoading state wrapper since it might be confusing to hear that there are items when the table/tree is empty
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:UNSTABLE_TreeLoadingIndicator-UNSTABLE_TreeLoadingIndicator <T extends {}> {
- children?: ReactNode | ((UNSTABLE_TreeLoadingIndicatorRenderProps & {
- defaultChildren: ReactNode | undefined
-})) => ReactNode
- className?: string | ((UNSTABLE_TreeLoadingIndicatorRenderProps & {
- defaultClassName: string | undefined
-})) => string
- style?: CSSProperties | ((UNSTABLE_TreeLoadingIndicatorRenderProps & {
- defaultStyle: CSSProperties
-})) => CSSProperties | undefined
-} /react-aria-components:UNSTABLE_TreeLoadingSentinel+UNSTABLE_TreeLoadingSentinel <T extends {}> {
+ children?: ReactNode | ((TreeLoadingSentinelRenderProps & {
+ defaultChildren: ReactNode | undefined
+})) => ReactNode
+ className?: string | ((TreeLoadingSentinelRenderProps & {
+ defaultClassName: string | undefined
+})) => string
+ isLoading?: boolean
+ onLoadMore?: () => any
+ scrollOffset?: number = 1
+ style?: CSSProperties | ((TreeLoadingSentinelRenderProps & {
+ defaultStyle: CSSProperties
+})) => CSSProperties | undefined
+} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RSP Component Milestones (view)
✅ Pull Request Checklist:
📝 Test Instructions:
Test Tree multiloading stories in RAC storybook. Also test all collections that support loading indicators (Table, Listbox, GridList, Tree, ComboBox, Picker, etc) and make sure that the virtualized items have the proper aria-rowcount/posinset/etc. Loaders shouldn't be counted as items/rows. Sanity check that other collections work fine virtualized/non-virtualized and that empty states/initial load states still render as expected
🧢 Your Project:
RSP