fix: preventFocus TypeError on window focus/blur during a press - #10592
Open
microbit-matt-hillsdon wants to merge 1 commit into
Open
fix: preventFocus TypeError on window focus/blur during a press#10592microbit-matt-hillsdon wants to merge 1 commit into
microbit-matt-hillsdon wants to merge 1 commit into
Conversation
preventFocus attaches focus and blur listeners to the window. When the window itself gains or loses focus the target is Window not a Node. Both helpers passed it straight into nodeContains, so Node.contains threw: TypeError: Failed to execute 'contains' on 'Node': parameter 1 is not of type 'Node'. Guard both calls with isNode and add a usePress test. Fixes adobe#10591
snowystinger
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preventFocus attaches focus and blur listeners to the window. When the window itself gains or loses focus the target is Window not a Node. Both helpers passed it straight into nodeContains, so Node.contains threw:
Guard both calls with isNode and add a usePress test.
Fixes #10591
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
I clicked around some storybook cases that exercise preventFocus (e.g. number field +/-) but that's for the happy path not so much the bug which was hard to reproduce, likely due to RAF timing, but seen in error logs.
🧢 Your Project:
micro:bit Python Editor