chore(review): 2026-04-11 audit — doc drift, a11y chip toggle, playba…#4
Merged
Conversation
…ckFilter edges - docs/system.md: remove 'signed outbound webhooks' from 'intentionally missing' (outbound HMAC signing has been live since 2026-04-10 — ADR-003, impl plan, README, and deliver-webhook.ts all agree it's shipped) - docs/contracts.md: - auth/setup: doc 400 -> code 409 (+ explicit 201 success shape) - auth/login: add documented 429 + Retry-After branch - auth/me: doc 500 -> code 404 - videos/:id/delete: add concrete response shape and the idempotent-repeat note - components/transcript-card/TranscriptControls.tsx: speaker-filter chips now expose aria-pressed + action-framed aria-label (a11y parity with the 2026-04-10 ARIA video-rail-tab fix) - components/TranscriptCard.speaker-selection.test.tsx: +1 test locking aria-pressed toggle behavior - components/player-card/playbackFilter.test.ts: +5 edge-case tests (duration guard, clamp, out-of-order input, non-finite/degenerate, filter-off passthrough) - docs/status.md, docs/cap5_implementation_plan.md: record the new coverage - docs/review-2026-04-11.md: dated review doc for this pass - scripts/ship-review-2026-04-11.sh: helper used to land these edits safely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ckFilter edges