Fix accessibility of theme toggle button #1669
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Alt + T
Alt + T
and not know what the button does.aria-label="Toggle theme"
makes the screen reader speak outToggle theme
which is the semantic purpose of the button without overriding the title or tooltipThis isn't perfect and the button could have a white rectangle around it as well for focus but wanted to just add this since it doesn't require me going into the CSS as a first PR
Was the change discussed in an issue or in the Discussions before?
Not that I am aware.
PR Checklist