Some code improvements.#32
Open
besser82 wants to merge 4 commits intoadegtyarev:masterfrom
Open
Conversation
f0bf464 to
b27bade
Compare
b27bade to
2acd81b
Compare
Contributor
2acd81b to
2497c8c
Compare
adegtyarev
reviewed
Nov 5, 2018
Owner
adegtyarev
left a comment
There was a problem hiding this comment.
Have you used a CLI tool for syntax checking?
I'd like to integrate that kind of checking to the CI/CD process with Travis. Any ideas?
OSX / XCode complains about duplicate symbols.
macOS may define 'ALIGN' with a different meaning if some system headers are included.
2497c8c to
1874ab5
Compare
|
Once you're doing this, please also remove Lines 119 to 120 in 8e41694 This command is useless in SSE2 mode (it's only needed to switch from MMX to x87), and it becomes an undefined function when MSVC compiler is used. |
|
Also Lines 127 to 128 in 8e41694 that translates to 64-bit movq, that is only available in x64 mode. Somehow GCC is able to translate it to several SSE instructions, but that's clearly an extension (MSVC refuses to do that). So the code compiles for Win64 but fails for Win32.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change 'uint512_u' to be a type, not a symbol.
OSX / XCode complains about duplicate symbols.
Rename 'uint512_u' to 'gost34112012_uint512_u' to avoid clashes.
Rename the 'ALIGN' macro to 'GOST3411_ALIGN'.
macOS may define 'ALIGN' with a different meaning if some system
headers are included.
Fix '-Wstringop-truncation'.
Use the unaligned version of '_mm_store_si128'.
This is needed for ix86 architectures, as for some unidentified
reason the memory address may not be 16 bytes aligned properly.
The information from the Intel Intrinsics Guide shows no speed
penalty between using the aligned or the unaligned version of
this function.
Remove trailing whitespace.