Use Windows_SDK.json from UE to determine what VS components to install #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
force-pushed
the
windows_sdk.json
branch
4 times, most recently
from
a7e1eff to
2982d7a
Compare
Collaborator
Author
|
Well. This PR successfully builds 5.6.1. I'm going to restore pre-5.4 compatibility (when Windows_SDK.json didn't exist) and then test all engines... |
slonopotamus
force-pushed
the
windows_sdk.json
branch
20 times, most recently
from
62c8e8a to
ad1d878
Compare
slonopotamus
force-pushed
the
windows_sdk.json
branch
from
ad1d878 to
5a1527c
Compare
Collaborator
Author
|
There is one problem with these changes - Build Tools are not present in ue4-minimal because it is copied on top of ue4-build-prerequisites. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft of how I would like to install VS so it matches what engine expects.
Closes #372
Closes #381
Closes #375
Closes #350
Changes are not properly tested yet. For engines older than 5.4 that do not have
Windows_SDK.json, I plan to hardcode fallback setup, like we do currently.@TBBle @adamrehn @Alexey31rus what do you think?
Engines tested so far: 5.2, 5.3, 5.4 5.5, 5.6