Fix intermediate variable declarations #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sage, variables are pushed onto the stack when they're declared. This leads to issues in expressions like this:
Here, the
matchexpression generates an intermediateletbinding for the bound expression'a'. It thinks that this variable is stored just above the last variable on the stack, but5is actually stored there, the stack frame has grown in the mean time. So, this PR adds tracking of the stack frame for intermediate value and correctly compiles the code above.