Ignore added "line clear" characters in the Web Workflow serial #9934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill88t
suggested changes
Jan 5, 2025
| @@ -43,6 +43,8 @@ ws.onmessage = function(e) { | |||
| } else if (e.data == "\x1b[K") { // Clear line | |||
| log.textContent = log.textContent.slice(0, -left_count); | |||
| left_count = 0; | |||
| } else if (e.data == "\x1b[2K\x1b[0G") { | |||
There was a problem hiding this comment.
It might be better to instead ignore every escape sequence.
This could be done really fast with ignoring everything from when we see "ESC[" to whenever we see an alphabet letter.
(65-90 or 97-122, the alphabet letter should be discarded too)
tannewt
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the printing of some control characters:
to
This just ignores the characters.
I don't think there is a need to implement erasing the line for the builtin web serial.