For atmel-samd release SERCOM on I2C deinit #10402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhalbert This should fix the issue Ross is seeing with I2C on his new board. I have not tested it myself, but it should be safe. |
|
@eightycc I understand the fix, but were you able to replicate the problem? Doing something like import board
i = board.I2C()
while True:
passand running it again and again does not seem to cause the problem. |
|
@dhalbert I didn't try to replicate the problem. The fix is based purely on the reported symptoms and my examination of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects an issue where creating a new
board.I2Cobject after a VM reset would throw aValueError: Invalid pins.This PR also fixes a minor typo in the https address of the current ARM Cortex toolchain.