Skip to content

Commit 64afc2c

Browse files
authored
Merge pull request #10859 from tannewt/fix_flaky_bsim
Tweak flaky test
2 parents aff6e32 + a358cd5 commit 64afc2c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ports/zephyr-cp/tests/bsim/conftest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,16 @@ def bsim_phy(request, bsim_phy_binary, native_sim_env, sim_id):
9797
sample_device_id = int(sample_marker.kwargs.get("device_id", 1))
9898
devices = max(devices, sample_device_id + 1)
9999

100-
sim_length_us = int(duration * 1e6)
100+
# Do not pass -sim_length: if the PHY exits on simulated time, device 0 can
101+
# still be flushing UART output and test output can get truncated. Instead,
102+
# let pytest own process lifetime and terminate the PHY at fixture teardown.
101103
cmd = [
102104
"stdbuf",
103105
"-oL",
104106
str(bsim_phy_binary),
105107
"-v=9", # Cleaning up level is on 9. Connecting is 7.
106108
f"-s={sim_id}",
107109
f"-D={devices}",
108-
f"-sim_length={sim_length_us}",
109110
]
110111
print("Running:", " ".join(cmd))
111112
proc = subprocess.Popen(

ports/zephyr-cp/zephyr-config/west.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ manifest:
44
projects:
55
- name: nrf_hw_models
66
url: https://github.com/tannewt/ext_nRF_hw_models
7-
revision: 24de78c485dce1a6048f8ae1c69a8d70c93b8cdd
7+
revision: bb351cef9e5ab4d175fe3cb7c4d6761d837bac20
88
path: modules/bsim_hw_models/nrf_hw_models
99
- name: zephyr
1010
url: https://github.com/adafruit/zephyr

0 commit comments

Comments
 (0)