[Refactor] AnalogIO->AnalogIn#193
Open
brentru wants to merge 10 commits into
Open
Conversation
Member
Author
|
On WipperSnapper Arduino, this refactor is part of the existing expander refactor (PR #913) |
lorennorman
approved these changes
May 12, 2026
tyeth
requested changes
May 13, 2026
Member
tyeth
left a comment
There was a problem hiding this comment.
As discussed today, it might make more sense to shift Gain to be a components custom properties rather than have to define each possibility in this enum ahead of time.
The ref voltage still makes sense here.
From Loren's summary of our talk:
basically we may want to expose a kind of language of custom properties that we can:
- implement however you want in the per-component firmware code
- add an arbitrary list of options/inputs to the json for that specific component
- web form draws it some way or other, stores selection in db
- protobufs have an optional sidecar for carrying this data
- firmware knows it will get one of the exact options that were put in the json
Member
Author
|
Related: #193 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
analogio.protowithanalogin.prototo properly define its operation in WipperSnapper.ref_voltage) rather than relying on the platform default.gainto boost signals.Resolves #191