-
Notifications
You must be signed in to change notification settings - Fork 43
Add I2C Output Component Type and Related Components #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lorennorman After renaming the files, the validation step seems stuck trying to query the old filename:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, although I'm not so sure on the i2c_output folder, maybe we add a direction(INPUT/OUTPUT/BLANK) to i2c components, or we plan for components that include multiple subcomponents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't ready for review, the auto-checker has not been satisfied and has valid complaints:
- cannot have capital letters in director names:
7Seg
,chartDisplay...
- component image must be named
image.png
(notquad.png
)
Hm, I'm not sure why GH isn't picking this change up. They are l-case on my system. I'm going to
Renamed! |
Realized I did not fully add |
@lorennorman Okay, fixed all the issues from the automated checks and added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@lorennorman Is this safe to merge? |
@brentru no, we need to make changes on the IO side to support a whole new component type. |
Ok. Hopefully this PR helps you scope out the breadth/depth of this work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tweaks, but looks great, nice work adding all these!
@tyeth Updated the JSON definitions to resolve your comments. Thank you for submitting them! |
This pull request introduces new component definitions for I2C output devices and a schema to validate these definitions.
New Component Definitions:
7-Segment LED Matrix
definition, including properties like I2C addresses, output type, alignment, and brightness. (components/i2c_output/7Seg/definition.json
)Quad Alphanumeric Display
definition, specifying properties such as I2C addresses, output type, alignment, and brightness. (components/i2c_output/QuadAlpha/definition.json
)16x2 Character Display
definition, detailing properties like I2C addresses, output type, and display dimensions. (components/i2c_output/charDisplay16x2/definition.json
)20x4 Character Display
definition, including properties such as I2C addresses, output type, and display dimensions. (components/i2c_output/charDisplay20x4/definition.json
)Resolves:
#254
#252
#251