EZO_PH #109
Closed
EZO_PH #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Dec 28, 2022
There was a problem hiding this comment.
@chunkystyle Thanks for adding this sensor! I do not personally own an EZO PH sensor. Are you intending to add the corresponding I2C device driver to the WipperSnapper Arduino repository?
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "displayName": "ezo_ph", | |||
| "published": true, | |||
There was a problem hiding this comment.
Please change to: "published": false, as a WipperSnapper firmware release containing this component does not yet exist.
|
Closing this pull request as stale. Please feel free to reopen, or create a new PR, if you'd like to continue with these changes. If you need any assistance, don't hesitate to reach out here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt at getting the Atlas Scientific PH meter.
https://atlas-scientific.com/embedded-solutions/ezo-ph-circuit/