[BUG] Fix busy status when callback not set #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorilandly
changed the title
|
@ladyada Can you take a look? Thanks a lot! |
|
hiya please clang-format and we can look at merging! |
|
@ladyada Done! |
ladyada
approved these changes
Oct 10, 2025
|
thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR fixes a bug that occurs when no callback is set. The job status is stuck at
busy, even if the job is finished, rendering the DMA module unusable. This PR corrects that and allow DMA to function correctly.Describe the scope of your change
This pull request changes the way it checks current status. Instead of checking
jobStatus, it reads the status registers directlyDescribe any known limitations with your change.
None
closes #17