feat(api): add methods to free DMA descriptors #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API prior this change only supports deallocating DMA channels (via method `(void)Adafruit_ZeroDMA::free(void)`), but it did not and **could not** deallocate the descriptor linked lists written to them. An _optional_ parameter was added to this method to also free the descriptor chain — but not by default — to retain backwards-compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the scope of your change--i.e. what the change does and what parts
of the code were modified.
The API prior this change only supports deallocating DMA channels (via method
(void)Adafruit_ZeroDMA::free(void)), but it did not and could not deallocate the descriptor linked lists written to them. An optional parameter was added to this method to also free the descriptor chain — but not by default — to retain backwards-compatibility.Describe any known limitations with your change.
None
Please run any tests or examples that can exercise your modified code.
Verified examples
zerodma_spi1andzerodma_spi2were functional on an ItsyBitsy M4