Repository navigation
Conversation
tyeth
force-pushed
the
add-arduino-nesso-n1
branch
from
November 22, 2025 22:38
907a2c0 to
79b19ed
Compare
tyeth
marked this pull request as ready for review
December 4, 2025 19:06
brentru
requested review from
brentru
and
a balanced review from Copilot
and removed request for
brentru
October 2, 2026 20:27
Member
|
@tyeth You mentioned there are some nesso changes which are v1-related, and the nesso board support is v2-related. This PR merges into |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unpublished board metadata, non-reproducible dependencies, truncated expander-pin IDs, and display side effects prevent reliable support.
Review effort: Balanced
Findings: 2
Open (5)
What changed in this PR
Adds Arduino Nesso-N1 ESP32-C6 support, including provisioning, display, battery, status LED, filesystem, PlatformIO, and CI integration.
Changes:
- Adds Nesso board configuration and build targets.
- Integrates onboard display, battery reporting, and expander-backed hardware.
- Extends status LED handling for inverted LEDs.
| File | Description |
|---|---|
src/Wippersnapper.h |
Declares Nesso battery instance. |
src/Wippersnapper.cpp |
Adds board-specific power initialization. |
src/Wippersnapper_Boards.h |
Defines Nesso board capabilities. |
src/provisioning/tinyusb/Wippersnapper_FS.cpp |
Formatting-only updates. |
src/provisioning/littlefs/WipperSnapper_LittleFS.cpp |
Enables Nesso LittleFS provisioning. |
src/components/statusLED/Wippersnapper_StatusLED.cpp |
Supports inverted and expander LEDs. |
src/components/pwm/ws_pwm.cpp |
Adds inverted PWM handling. |
src/components/display/drivers/dispDrvSt7789.h |
Adds onboard display and battery support. |
src/components/display/drivers/dispDrvBase.h |
Extends the battery-icon interface. |
src/components/display/controller.cpp |
Reports Nesso battery level. |
src/components/display/assets/icons.h |
Adds battery-level icons. |
src/components/digitalIO/Wippersnapper_DigitalGPIO.h |
Declares expander-pin services. |
src/components/digitalIO/Wippersnapper_DigitalGPIO.cpp |
Implements expander-pin services. |
platformio.ini |
Adds Nesso dependencies and environment. |
examples/Wippersnapper_demo/.arduino_nesso_n1.generate |
Enables demo generation. |
examples/wippersnapper_debug/.arduino_nesso_n1.test.skip |
Skips the debug example. |
.github/workflows/build-clang-doxy.yml |
Adds Nesso CI builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ; Common build environment for ESP32 platform | ||
| [common:esp32] | ||
| platform = https://github.com/pioarduino/platform-espressif32/releases/download/55.03.33/platform-espressif32.zip | ||
| platform = https://github.com/tyeth/platform-espressif32/releases/download/55.03.33-nesso.1/platform-espressif32-55.03.33-nesso.1.zip |
Comment on lines
+64
to
+65
| int digitalReadSvc(ExpanderPin pinName); | ||
| void digitalWriteSvc(ExpanderPin pinName, int pinValue); |
| with: | ||
| repository: adafruit/Wippersnapper_Boards | ||
| path: ws-boards | ||
| ref: arduino-nesso-n1 |
Comment on lines
+70
to
+71
| #elif defined(ARDUINO_ARDUINO_NESSO_N1) | ||
| digitalWrite(LCD_BACKLIGHT, LOW); |
| board_build.filesystem = littlefs | ||
| board_build.partitions = min_spiffs.csv | ||
|
|
||
| ; Arduino Nesso-N1 (Espressif ESP32-C5 16MB FLASH) |
Member
Author
Yep, intention is to leave only the status bar battery icon changes, as expander pins are a v2 concept. |
Member
|
@tyeth OK - is this PR ready for review then? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs boards repo entry before will compile in CI. Expected to fail, will retry job after adding board definition.
Compiles locally with arduino-cli and platformIO.
PlatformIO needs this PR: pioarduino/platform-espressif32#345
or this release: https://github.com/tyeth/platform-espressif32/releases/tag/55.03.33-nesso.1 [Updated Variant]
Closes adafruit/Wippersnapper_Boards#223