[API v1]: Add support for I2C Output Components - #751
Merged
Conversation
brentru
marked this pull request as ready for review
May 15, 2025 18:50
tyeth
approved these changes
May 16, 2025
tyeth
requested changes
May 16, 2025
Member
Author
|
@tyeth Re-requesting a review since I've incorporated your changes and added the SSD1306 driver to this PR. |
tyeth
reviewed
May 21, 2025
tyeth
left a comment
tyeth
left a comment
Member
There was a problem hiding this comment.
Looks good, can't wait to test it!
The OLED max hours comment is worth thinking about. I can imagine an action where a user displayed the new data for 5-30 minutes on schedule or button press/trigger, before turning off. Or could be hours based (daytime etc). Eventually dimmed at night would be cool (especially for alarm clocks)
5 tasks
Member
Author
|
Holding until Prod. is released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances core I2C functionality by adding support for I2C output devices. This is a backport of #749 to work with the v1 WipperSnapper Protocol Buffer API.
The following I2C Output Devices are supported by this pull request:
Addresses: adafruit/Wippersnapper_Protobuf#144
Resolves: #742
Full Diff (Automatically Generated using Copilot Summary)
Support for New I2C Output Devices:
WipperSnapper_I2C_Driver_Out,WipperSnapper_I2C_Driver_Out_QuadAlphaNum, andWipperSnapper_I2C_Driver_Out_CharLcd. These classes encapsulate the functionality required to interact with these devices. (src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out.h,src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_CharLcd.h) [1] [2]Updates to I2C Initialization and Deinitialization:
initI2CDeviceto initialize the new output devices (quadalphanumandcharlcd) with specific configurations such as brightness and alignment for LED backpacks and row/column setup for character LCDs. (src/components/i2c/WipperSnapper_I2C.cpp)deinitI2CDeviceto properly handle the removal of output drivers, ensuring compatibility with both ESP-IDF and Arduino architectures. (src/components/i2c/WipperSnapper_I2C.cpp)Handling I2C Output Operations:
Handle_I2cDeviceOutputWriteto process messages for output devices, including writing text or numeric values to LED backpacks and character LCDs. (src/components/i2c/WipperSnapper_I2C.cpp,src/components/i2c/WipperSnapper_I2C.h) [1] [2]Dependency Updates:
library.propertiesandplatformio.inito include new dependencies for the Adafruit LED Backpack and LiquidCrystal libraries, ensuring the required libraries are available for the new functionality. (library.properties,platformio.ini) [1] [2]Debugging and Logging:
src/Wippersnapper.cpp,src/components/i2c/WipperSnapper_I2C.cpp) [1] [2]These changes significantly expand the WipperSnapper framework's capabilities, enabling support for a broader range of I2C devices and improving the overall robustness of the I2C handling logic.