CDC Notification Endpoint, so we can send DSR/DCD/RI. - #493
CDC Notification Endpoint, so we can send DSR/DCD/RI.#493SmittyHalibut wants to merge 16 commits into
Conversation
|
Figured it out. I was queueing the notification in the callback, which only gets called after the notification is sent. I moved the queueing to set_serial_state instead, and call it again from the call back in case the state changed while we were notifying of the last change. And some other general clean up too. |
|
I had to move Let me know if you'd prefer to accept the build-check failures and keep the |
|
Another failed build check, but this one doesn't look related to my changes: |
|
I submitted #500 for the build issues. |
| @@ -1,2 +1,3 @@ | |||
| pico_rp2040_tinyusb_host | |||
| CH32V20x_EVT | |||
| feather_rp2040_tinyusb | |||
| @@ -1,2 +1,3 @@ | |||
| pico_rp2040_tinyusb_host | |||
| CH32V20x_EVT | |||
| feather_rp2040_tinyusb | |||
| @@ -1 +1,2 @@ | |||
| pico_rp2040_tinyusb_host | |||
| feather_rp2040_tinyusb | |||
SmittyHalibut
changed the title
|
Fixed merge conflicts. |
1 participant
See #491
The goal is to implement the Notification endpoint in the CDC ACM spec so we can send hardware flow control signals up to the host.
Draft for now. I'm looking for code reviews. For the obvious stuff: style, improvements, etc.But also: It doesn't work yet. My computer doesn't seem to be sending events to the Notification endpoint. At least, my code doesn't seem to be getting triggered at all.I am NOT an expert at USB stack coding (this is my first time.) I'm hoping there's a simple "Oh, you forgot that it's Thursday. You need to flip this bit and tickle that widget and poke this bear, and it'll work."There's some extra debugging code in here that I'll remove before fully submitting the PR; it's in there for testing.Figured it out; see below.