Skip to content

Conversation

FoamyGuy
Copy link
Contributor

And set the default method to NEAREST which "pixel perfect" scaling when used with something pixel arty that is scaled up by an even multiple of it's real size i.e. pico8 running at 768x768 to match the height of the display, but then being resized by PIL down to 128x128. With the NEAREST sampling method the result is 1:1 pixels with the original resolution of pico8 128x128.

Users can specify the other resample methods with the new command line argument for xdisplay_mirror

@FoamyGuy FoamyGuy requested a review from jepler March 12, 2025 16:18
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! One small improvement to suggest tho.

@jepler
Copy link
Contributor

jepler commented Mar 12, 2025

  --resample-method [nearest|bilinear|lanczos|bicubic]
                                  The resample method for PIL to use when
                                  resizing the screen image.

the help will even list the methods this way

@jepler
Copy link
Contributor

jepler commented Mar 12, 2025

it doesn't list the default so that may be useful to leave in

@FoamyGuy
Copy link
Contributor Author

Main is merged and conflicts resolved with the latest commit

@FoamyGuy FoamyGuy requested a review from jepler March 13, 2025 21:27
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jepler jepler merged commit b19b6c7 into adafruit:main Mar 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants