🐛 (mobile) fix amount input requiring two clicks on safari mobile #4182
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
MatissJanis
changed the title
WalkthroughThe pull request introduces changes to handle a specific iOS-related user interaction issue in the transaction editing process. A new dependency Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (1)
73-74: Consider enhancing browser detection robustness.While the current implementation works, consider using feature detection instead of user agent parsing for more reliable iOS detection. For example:
const isIOSAgent = () => { return ( typeof window !== 'undefined' && /iPad|iPhone|iPod/.test(navigator.platform || '') || (navigator.platform === 'MacIntel' && navigator.maxTouchPoints > 1) ); };This approach is more resilient to user agent changes and better handles iPad devices in desktop mode.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
upcoming-release-notes/4182.mdis excluded by!**/*.mdyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
packages/desktop-client/package.json(1 hunks)packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx(6 hunks)
🔇 Additional comments (4)
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (3)
19-19: LGTM! Browser detection is correctly implemented.The addition of
UAParserand the browser detection logic aligns well with the PR objective of fixing the iOS Safari-specific issue.Also applies to: 73-74
472-476: LGTM! State initialization handles iOS focus correctly.The conditional initialization of
totalAmountFocusedbased onisIOSAgenteffectively addresses the iOS-specific focus issue. The comment clearly explains the rationale.
493-493: LGTM! Effect hook correctly handles iOS focus behavior.The addition of
!isIOSAgentto the condition ensures that automatic focus is disabled on iOS devices, consistent with the fix for the double-click issue.packages/desktop-client/package.json (1)
73-73: Verify the security status of ua-parser-js.The dependency version looks good, but let's verify it for any known security vulnerabilities.
✅ Verification successful
✅ [email protected] is secure
The specified version is the latest available and is not affected by any known security vulnerabilities.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for security advisories for ua-parser-js gh api graphql -f query=' { securityVulnerabilities(first: 5, ecosystem: NPM, package: "ua-parser-js") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange firstPatchedVersion { identifier } } } }' # Check latest version on npm curl -s https://registry.npmjs.org/ua-parser-js/latest | jq '.version'Length of output: 1435
Fixed #2392
The focus trigger for Safari on iOS does not work as expected. This is a known issue for PWAs on iOS. So the workaround is to remote the auto-focus explicitly for these devices.