single_store: added support for handling multiple contexts on the host #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
reviewed
Feb 20, 2025
|
Thanks for the review!
Yes, this is next on my to do list |
tsulaiav
force-pushed
the
main-single_store-ctx
branch
from
55284bd to
abefb11
Compare
niermann999
approved these changes
Feb 28, 2025
tsulaiav
force-pushed
the
main-single_store-ctx
branch
from
abefb11 to
9affcac
Compare
|
I have implemented the comments and added a unit test. I expect the CI run to fail. Hopefully, it will be fixed after we merge #946 |
tsulaiav
force-pushed
the
main-single_store-ctx
branch
2 times, most recently
from
a609c54 to
0dade4a
Compare
tsulaiav
force-pushed
the
main-single_store-ctx
branch
from
0dade4a to
6524bd0
Compare
|
Hi @niermann999, I temporarily commented out the problematic part of the new unit test. That's why the CI has succeeded. We should uncomment this code once the issue with |
niermann999
reviewed
Mar 5, 2025
…text arguments This was done to prevent passing around arguments in invalid state. Also temporarily disabled the part of the multicontext_transform_store test until the issue with EXPECT_POINT3_NEAR() in smatrix has been fixed
tsulaiav
force-pushed
the
main-single_store-ctx
branch
from
6524bd0 to
bb9ba60
Compare
niermann999
approved these changes
Mar 11, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.