ref: Make surface implementation more concise #861
+715
−640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-split-surface
branch
2 times, most recently
from
a0fe7b1 to
4b59995
Compare
niermann999
added
refactor
niermann999
force-pushed
the
ref-split-surface
branch
3 times, most recently
from
cf35a42 to
50de9ca
Compare
niermann999
force-pushed
the
ref-split-surface
branch
2 times, most recently
from
f46326a to
51058a6
Compare
|
niermann999
force-pushed
the
ref-split-surface
branch
6 times, most recently
from
793a7dc to
216b951
Compare
niermann999
force-pushed
the
ref-split-surface
branch
from
216b951 to
6c136ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the basic geometric surface interface type as concise as possible and instead only add additional functionality around it when actually needed. Also moves a few pieces of functionality to specialized free functions. The
tracking_surfaceinterface and functionality does not change and can continue to be used as is in tracking focused projects like traccc.This is an attempt to reduce internal coupling, because most of the tracking surface functionality is only needed in very few places. It will also allow for non-tracking focused projects to not depend on tracking functionality in any way
Note: This PR also follows this recommendation https://sonarcloud.io/project/issues?open=AZPfWgeq_bLRcF2RbOJs&id=acts-project_detray&tab=why