feat: loop unrolling and switch to constexpr #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-loop-unrolling
branch
2 times, most recently
from
c00df79 to
145e1af
Compare
niermann999
force-pushed
the
feat-loop-unrolling
branch
from
145e1af to
f5377ae
Compare
niermann999
force-pushed
the
feat-loop-unrolling
branch
from
f5377ae to
0091cf8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces the compiler to apply loop unrolling in the Vc plugins, which seems to help performance (the array plugin seems to be optimized that way already). For this, a new macro was added to the qualifiers header to do this per compiler (however, I could not find anything for MSVC so far). I think it is OK to mandate loop unrolling at some loops that seem to make sense, since we don't have large matrices to run
Since
constexprimpliesinlinemost functions were switched toconstexprnow.