Skip to content

Simplify dependency structure #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,10 @@ jobs:
CONTAINER: "ghcr.io/acts-project/ubuntu2404:67"
OPTIONS: --preset eigen
RUN_TESTS: true
- NAME: "HOST"
CONTAINER: "ghcr.io/acts-project/ubuntu2404:56"
OPTIONS: -DALGEBRA_PLUGINS_INCLUDE_SMATRIX=TRUE
RUN_TESTS: true
- NAME: "HOST"
CONTAINER: "ghcr.io/acts-project/ubuntu2404:67"
OPTIONS: --preset vc
RUN_TESTS: true
- NAME: "HOST"
CONTAINER: "ghcr.io/acts-project/ubuntu2404:67"
OPTIONS: --preset vecmem
RUN_TESTS: true
- NAME: "HOST"
CONTAINER: "ghcr.io/acts-project/ubuntu2404:67"
OPTIONS: --preset fastor
Expand Down
20 changes: 0 additions & 20 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,10 @@ set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY
# Flags controlling how the Algebra Plugins code should behave.
option( ALGEBRA_PLUGINS_INCLUDE_EIGEN
"Include Eigen types in Algebra Plugins" FALSE )
option( ALGEBRA_PLUGINS_INCLUDE_SMATRIX
"Include Smatrix types in Algebra Plugins" FALSE )
option( ALGEBRA_PLUGINS_INCLUDE_VC
"Include Vc types in Algebra Plugins" FALSE )
option( ALGEBRA_PLUGINS_INCLUDE_FASTOR
"Include Fastor types in Algebra Plugins" FALSE )
option( ALGEBRA_PLUGINS_INCLUDE_VECMEM
"Include VecMem types in Algebra Plugins" FALSE )
option( ALGEBRA_PLUGINS_BUILD_TESTING "Build the unit tests of Algebra Plugins"
TRUE )
option( ALGEBRA_PLUGINS_BUILD_BENCHMARKS "Build the benchmark suite of Algebra Plugins"
Expand All @@ -68,22 +64,6 @@ if( NOT DEFINED CMAKE_SUPPRESS_DEVELOPER_WARNINGS )
set( _unsetDevWarningFlag TRUE )
endif()

# Set up VecMem.
option( ALGEBRA_PLUGINS_SETUP_VECMEM
"Set up the VecMem target(s) explicitly" TRUE )
option( ALGEBRA_PLUGINS_USE_SYSTEM_VECMEM
"Pick up an existing installation of VecMem from the build environment"
${ALGEBRA_PLUGINS_USE_SYSTEM_LIBS} )
if( ALGEBRA_PLUGINS_SETUP_VECMEM )
if( ALGEBRA_PLUGINS_USE_SYSTEM_VECMEM )
find_package( vecmem 0.7.0 REQUIRED COMPONENTS LANGUAGE )
else()
add_subdirectory( extern/vecmem )
# Make the "VecMem language code" available for the whole project.
include( "${VECMEM_LANGUAGE_DIR}/vecmem-check-language.cmake" )
endif()
endif()

# Set up GoogleTest.
option( ALGEBRA_PLUGINS_SETUP_GOOGLETEST
"Set up the GoogleTest target(s) explicitly" TRUE )
Expand Down
20 changes: 5 additions & 15 deletions CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@
"ALGEBRA_PLUGINS_USE_SYSTEM_LIBS" : "FALSE"
}
},
{
"name" : "vecmem",
"displayName" : "VecMem Enabled Configuration",
"inherits" : [ "base" ],
"cacheVariables": {
"ALGEBRA_PLUGINS_SETUP_VECMEM" : "TRUE",
"ALGEBRA_PLUGINS_INCLUDE_VECMEM" : "TRUE"
}
},
{
"name" : "eigen",
"displayName" : "Eigen Enabled Configuration",
Expand Down Expand Up @@ -54,28 +45,27 @@
{
"name" : "default-x86-64",
"displayName" : "Default Developer Configuration for x86_64",
"inherits" : [ "vecmem", "eigen", "vc", "fastor" ]
"inherits" : [ "eigen", "vc", "fastor" ]
},
{
"name" : "default-aarch64",
"displayName" : "Default Developer Configuration for ARM64",
"inherits" : [ "vecmem", "eigen", "vc" ]
"inherits" : [ "eigen", "vc" ]
},
{
"name" : "cuda",
"displayName" : "CUDA Developer Configuration",
"inherits" : [ "vecmem", "eigen" ],
"inherits" : [ "eigen" ],
"cacheVariables" : {
"ALGEBRA_PLUGINS_TEST_CUDA" : "TRUE"
}
},
{
"name" : "sycl",
"displayName" : "SYCL Developer Configuration",
"inherits" : [ "vecmem", "eigen" ],
"inherits" : [ "eigen" ],
"cacheVariables" : {
"ALGEBRA_PLUGINS_TEST_SYCL" : "TRUE",
"VECMEM_BUILD_SYCL_LIBRARY" : "TRUE"
"ALGEBRA_PLUGINS_TEST_SYCL" : "TRUE"
}
}
]
Expand Down
8 changes: 1 addition & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ for the R&D projects [detray](https://github.com/acts-project/detray) and
| ------------------------------------------------------------------------- | --- | ---- | ---- |
| generic | ✅ | ✅ | ✅ |
| [Eigen](https://eigen.tuxfamily.org) | ✅ | ✅ | ✅ |
| [SMatrix](https://root.cern.ch/doc/master/group__SMatrixGroup.html) | ✅ | ⚪ | ⚪ |
| [VC](https://github.com/VcDevel/Vc) | ✅ | ⚪ | ⚪ |
| [Fastor](https://github.com/romeric/Fastor) | ✅ | ⚪ | ⚪ |

Expand All @@ -28,18 +27,13 @@ Available options:
the following plugins:
* `EIGEN`: Plugin using [Eigen](https://eigen.tuxfamily.org)
(`OFF` by default)
* `SMATRIX`: Plugin using
[SMatrix](https://root.cern/doc/master/group__SMatrixGroup.html)
(`OFF` by default)
* `VC`: Plugin using [Vc](https://github.com/VcDevel/Vc)
(`OFF` by default)
* `FASTOR`: Plugin using [Fastor](https://github.com/romeric/Fastor)
(`OFF` by default)
* `VECMEM`: Plugin using [VecMem](https://github.com/acts-project/vecmem)
(`OFF` by default)
- `ALGEBRA_PLUGINS_USE_SYSTEM_LIBS`: Boolean configuring whether to search for all external libraries "on the system" or not
- `ALGEBRA_PLUGINS_SETUP_<XXX>`: Boolean to turn on/off the explicit "setup" of
the external libraries (`GOOGLETEST`, [`BENCHMARK`](https://github.com/google/benchmark), `EIGEN3`, `VC`, `FASTOR`, and `VECMEM`)
the external libraries (`GOOGLETEST`, [`BENCHMARK`](https://github.com/google/benchmark), `EIGEN3`, `VC`, `FASTOR`)
- `ALGEBRA_PLUGINS_USE_SYSTEM_<XXX>`: Boolean configuring how to set up a given
external library
* `ON`: The external library is searched for "on the system" using
Expand Down
29 changes: 0 additions & 29 deletions cmake/algebra-plugins-compiler-options-sycl.cmake

This file was deleted.

8 changes: 0 additions & 8 deletions cmake/algebra-plugins-config.cmake.in
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
# Set up variables describing which plugins were enabled during the Algebra
# Plugins build.
set( ALGEBRA_PLUGINS_INCLUDE_EIGEN @ALGEBRA_PLUGINS_INCLUDE_EIGEN@ )
set( ALGEBRA_PLUGINS_INCLUDE_SMATRIX @ALGEBRA_PLUGINS_INCLUDE_SMATRIX@ )
set( ALGEBRA_PLUGINS_INCLUDE_VC @ALGEBRA_PLUGINS_INCLUDE_VC@ )
set( ALGEBRA_PLUGINS_INCLUDE_VECMEM @ALGEBRA_PLUGINS_INCLUDE_VECMEM@ )

# Set up some simple variables for using the package.
set( algebra_plugins_VERSION "@PROJECT_VERSION@" )
Expand All @@ -25,15 +23,9 @@ include( CMakeFindDependencyMacro )
if( ALGEBRA_PLUGINS_INCLUDE_EIGEN )
find_dependency( Eigen3 )
endif()
if( ALGEBRA_PLUGINS_INCLUDE_SMATRIX )
find_dependency( ROOT COMPONENTS Smatrix )
endif()
if( ALGEBRA_PLUGINS_INCLUDE_VC )
find_dependency( Vc 1.4.2 )
endif()
if( ALGEBRA_PLUGINS_INCLUDE_VECMEM )
find_dependency( vecmem )
endif()

# Print a standard information message about the package being found.
include( FindPackageHandleStandardArgs )
Expand Down
35 changes: 0 additions & 35 deletions extern/vecmem/CMakeLists.txt

This file was deleted.

4 changes: 0 additions & 4 deletions extern/vecmem/README.md

This file was deleted.

11 changes: 0 additions & 11 deletions frontend/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,11 @@
add_subdirectory( array_cmath )

if( ALGEBRA_PLUGINS_INCLUDE_EIGEN )
add_subdirectory( eigen_generic )
add_subdirectory( eigen_eigen )
endif()

if( ALGEBRA_PLUGINS_INCLUDE_SMATRIX )
add_subdirectory( smatrix_generic )
add_subdirectory( smatrix_smatrix )
endif()

if( ALGEBRA_PLUGINS_INCLUDE_VC )
add_subdirectory( vc_aos )
add_subdirectory( vc_aos_generic )
if( NOT "${CMAKE_CXX_COMPILER_ID}" MATCHES "AppleClang" )
add_subdirectory( vc_soa )
endif()
Expand All @@ -28,7 +21,3 @@ endif()
if( ALGEBRA_PLUGINS_INCLUDE_FASTOR )
add_subdirectory( fastor_fastor )
endif()

if( ALGEBRA_PLUGINS_INCLUDE_VECMEM )
add_subdirectory( vecmem_cmath )
endif()
14 changes: 0 additions & 14 deletions frontend/eigen_generic/CMakeLists.txt

This file was deleted.

Loading