Novalnet Direct Debit ACH payment icon added #1313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Novalnet-Technic can you please fix the following issue in your SVG? Failure: bin/rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 |
|
Hello @dannye0231 , Thanks for your feedback. We have fixed the mentioned issue in our last commit - ‘Review Changes.’ Please check and let us know if you have any further feedback. |
dannye0231
requested review from
Lydia-shan-git,
johnchanshopify and
claudiomunoz
|
@Novalnet-Technic are you able to further optimize the SVG? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.ymlIf this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
We are working with the Shopify team on payment extensions. Since no specific contact was provided, we are following Shopify’s official guidelines and processes for adding these icons
What's the expected date of this change to deploy on Shopify?
As soon as possible