-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CBC payment icon #1243
Add CBC payment icon #1243
Conversation
Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated? |
Hi. Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated? |
@danielcivit we are aiming to merge again on Feb 5th. Can you please re-base this PR as well? |
Hello @dannye0231. It's done. |
@danielcivit can you please re-base? There is a conflict with this PR |
Hi @dannye0231 It's done. Conflict is solved. Thanks. |
Why are you adding this icons?
This icon is missing, and somehow the existing icon database suggests using the same one as KBC for CBC since this one uses a name that points to both brands.
That approach might be correct in the past but we think is not correct these days. MultiSafepay, offers KBC and CBC as different payment gateways. And when a customer select any of these payment methods, it will be redirected to different endpoints.
In the next step, maybe we can suggest deprecating the "kbc_cbc" payment icon, and provide another option named "kbc" to prevent confusion.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?