Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temp-directory input #15

Closed
wants to merge 1 commit into from
Closed

Conversation

ncfavier
Copy link
Contributor

Useful when runner.temp does not exist, e.g. in container environments

Useful when `runner.temp` does not exist, e.g. in container environments
@ncfavier ncfavier requested a review from a team as a code owner August 16, 2022 22:45
@yoannchaudet
Copy link
Contributor

Hmm do you know under what conditions runner.temp is unavailable?

On this run, I am running in a container and have the volume available just fine.

@ncfavier
Copy link
Contributor Author

ncfavier commented Aug 19, 2022

What makes you conclude that? tar fails because of --hard-dereference before it has a chance to complain about the target directory missing. (which is another issue by the way)

From what I can tell, the containers are created with -v "/home/runner/work/_temp":"/__w/_temp" so the temporary directory is in fact available at /__w/_temp, but this isn't reflected in runner.temp. Maybe it should be? Or maybe we can do something like "if job.container.id is set then use /__w/_temp else use runner.temp" but that's a hack.

@ncfavier ncfavier marked this pull request as draft August 19, 2022 12:51
@Sleavely
Copy link

Since there is no issue tracking it, I'll barge in and drop a comment here because I'm in similar situation where it complains about the /home/runner/work/_temp/artifact.tar file not existing: workflow run

In my case I could easily work around it since the container I use is basically just a pre-installed NodeJS, so switching to the setup-node action solved it for me (commit, workflow run).

@nilsvu
Copy link

nilsvu commented Aug 30, 2022

Opened this issue before I saw the PR: #20

@ncfavier ncfavier closed this Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants