windows support via cross-env #1059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Adds cross-platform environment variable support for Windows by incorporating cross-env into test-related scripts.
- Updated
ci-testandtestscripts to prefix environment variables withcross-env - Added
cross-envto dependencies for out-of-the-box Windows compatibility
| @@ -24,15 +24,15 @@ | |||
| }, | |||
| "scripts": { | |||
| "bundle": "npm run format:write && npm run package", | |||
| "ci-test": "NODE_OPTIONS=--experimental-vm-modules NODE_NO_WARNINGS=1 npx jest", | |||
| "ci-test": "cross-env NODE_OPTIONS=--experimental-vm-modules NODE_NO_WARNINGS=1 npx jest", | |||
There was a problem hiding this comment.
[nitpick] The ci-test and test scripts are nearly identical; consider extracting the common invocation into a shared npm script (e.g., env-test) to reduce duplication.
Suggested change
| "ci-test": "cross-env NODE_OPTIONS=--experimental-vm-modules NODE_NO_WARNINGS=1 npx jest", | |
| "ci-test": "npm run env-test", | |
| "env-test": "cross-env NODE_OPTIONS=--experimental-vm-modules NODE_NO_WARNINGS=1 npx jest", |
Copilot uses AI. Check for mistakes.
| @@ -50,6 +50,7 @@ | |||
| "@types/node": "^20.17.48", | |||
| "@typescript-eslint/eslint-plugin": "^8.32.1", | |||
| "@typescript-eslint/parser": "^8.32.1", | |||
| "cross-env": "^7.0.3", | |||
There was a problem hiding this comment.
[nitpick] Consider updating the project README to note the addition of cross-env and clarify that Windows users can now run scripts without manual environment setup.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add out of the box experience for windows users.