-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update commenter type #1177
Open
jayudey-wf
wants to merge
3
commits into
actions:main
Choose a base branch
from
jayudey-wf:update-commenter-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update commenter type #1177
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1209,7 +1209,7 @@ test('stale issues should not be closed if days is set to -1', async () => { | |||||
expect(processor.removedLabelIssues).toHaveLength(0); | ||||||
}); | ||||||
|
||||||
test('stale label should be removed if a comment was added to a stale issue', async () => { | ||||||
test('stale label should be removed if a User comment was added to a stale issue', async () => { | ||||||
const opts = {...DefaultProcessorOptions, removeStaleWhenUpdated: true}; | ||||||
const TestIssueList: Issue[] = [ | ||||||
generateIssue( | ||||||
|
@@ -1247,6 +1247,44 @@ test('stale label should be removed if a comment was added to a stale issue', as | |||||
expect(processor.removedLabelIssues).toHaveLength(1); | ||||||
}); | ||||||
|
||||||
test('stale label should not be removed if a Bot comment was added to a stale issue', async () => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
const opts = {...DefaultProcessorOptions, removeStaleWhenUpdated: true}; | ||||||
const TestIssueList: Issue[] = [ | ||||||
generateIssue( | ||||||
opts, | ||||||
1, | ||||||
'An issue that should un-stale', | ||||||
'2020-01-01T17:00:00Z', | ||||||
'2020-01-01T17:00:00Z', | ||||||
false, | ||||||
false, | ||||||
['Stale'] | ||||||
) | ||||||
]; | ||||||
const processor = new IssuesProcessorMock( | ||||||
opts, | ||||||
alwaysFalseStateMock, | ||||||
async p => (p === 1 ? TestIssueList : []), | ||||||
async () => [ | ||||||
{ | ||||||
user: { | ||||||
login: 'notme', | ||||||
type: 'Bot' | ||||||
}, | ||||||
body: 'Body' | ||||||
} | ||||||
], // return a fake comment to indicate there was an update | ||||||
async () => new Date().toDateString() | ||||||
); | ||||||
|
||||||
// process our fake issue list | ||||||
await processor.processIssues(1); | ||||||
|
||||||
expect(processor.closedIssues).toHaveLength(1); | ||||||
expect(processor.staleIssues).toHaveLength(0); | ||||||
expect(processor.removedLabelIssues).toHaveLength(0); | ||||||
}); | ||||||
|
||||||
test('when the option "labelsToAddWhenUnstale" is set, the labels should be added when unstale', async () => { | ||||||
expect.assertions(4); | ||||||
const opts = { | ||||||
|
@@ -1360,7 +1398,7 @@ test('stale label should not be removed if a comment was added by the bot (and t | |||||
{ | ||||||
user: { | ||||||
login: 'abot', | ||||||
type: 'User' | ||||||
type: 'Bot' | ||||||
}, | ||||||
body: 'This issue is stale' | ||||||
} | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.