Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache-save: false option #762

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 10, 2023

Description

This PR adds a new cache-save: false option to opt out of saving the cache. As described in the documentation:

For some scenarios, it may be useful to only save a given subset of dependencies,
but restore more of them for other workflows. For instance, there may be a heavy
extras dependency that you do not need your entire test matrix to download, but
you want to download and test it separately without it being saved in the cache
archive for all runs.

To achieve this, you can use cache-save: false on the run that uses the heavy
dependency.

Related issue

I only found the related issue after implementing this: #751.

Check list

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@akx akx requested a review from a team as a code owner November 10, 2023 08:30
@akx akx force-pushed the no-save-cache-options branch from 346329c to 59d62e4 Compare November 10, 2023 13:35
@akx akx force-pushed the no-save-cache-options branch from 59d62e4 to 8f0a0b0 Compare December 12, 2023 13:27
@akx
Copy link
Contributor Author

akx commented Dec 12, 2023

Rebased on v5.

@dmitry-shibanov Could you review this, please?

@ozancaglayan
Copy link

Could someone please take an action for this PR and release a new version? 🙏

@ozancaglayan
Copy link

@akx can you request review from the maintainers here? @priya-kinthali @aparnajyothi-y @HarithaVattikuti

@akx
Copy link
Contributor Author

akx commented Oct 10, 2024

@ozancaglayan As an external, I have no option to request a reviewer. GitHub does say "actions/setup-actions-team was requested for review"...

kdeldycke added a commit to kdeldycke/workflows that referenced this pull request Dec 24, 2024
@aparnajyothi-y
Copy link
Contributor

aparnajyothi-y commented Dec 30, 2024

Hello Everyone, Thank you for your contribution with this PR.
While we appreciate the idea, we’re concerned that it may introduce additional complexity and could potentially limit caching benefits. Furthermore, it would require ongoing maintenance and updates to documentation. Given these factors, we’ve decided to not move forward with this change at this time.

We truly appreciate your understanding and patience, and we encourage you to continue sharing any further thoughts or suggestions you may have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants