[helm]feat: add fullname override option for gha-runner-scale-set #3854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4po
requested review from
a team,
mumoshu,
rentziass and
toast-gear
as code owners
c4po
changed the title
c4po
force-pushed
the
override-fullname
branch
from
739ea2c to
dd0e626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I want to introduce a feature in the gha-runner-scale-set Helm chart that allows users to override the
gha-runner-scale-set.fullnamefrom the values.yaml file. This feature is necessary to support the installation of two runner scale sets in the same namespace with the same scale set name but targeting different GitHub configuration URLs. This is particularly useful for us to migrate runner sets from GitHub Enterprise Server (GHES) to GitHub Enterprise Cloud (GHEC).Changes
fullnameOverridefield invalues.yamlto allow users to specify a custom full name for the runner scale set._helpers.tplto use the override value if provided, enabling deployment of multiple runner scale sets in the same namespace with different GitHub configuration URLs.