-
Notifications
You must be signed in to change notification settings - Fork 18
chore: Drop legacy V3 support #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@amateima @melisaguevara @james-a-morris This PR drops support for legacy V3 events, meaning they won't be able to be queried via the SpokePoolClient anymore. @amateima noted that you're still indexing older events, so I just wanted to check it off with you to confirm if/when this is OK to merge RE the indexer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indexer should be good to go - this may be worth as a breaking version bump
@james-a-morris @amateima I think we should wait until we finish the production backfilling to merge this. Do you agree? |
The UMIP permits support for these events to be dropped as early as 7 days post-upgrade. This cleanup is a necessary prerequisite for adding non-EVM support.