Skip to content

chore: Drop legacy V3 support #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

chore: Drop legacy V3 support #906

wants to merge 15 commits into from

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Feb 28, 2025

The UMIP permits support for these events to be dropped as early as 7 days post-upgrade. This cleanup is a necessary prerequisite for adding non-EVM support.

@pxrl pxrl changed the title chore: Drop V3 support chore: Drop legacy V3 support Feb 28, 2025
@pxrl
Copy link
Contributor Author

pxrl commented Mar 20, 2025

@amateima @melisaguevara @james-a-morris This PR drops support for legacy V3 events, meaning they won't be able to be queried via the SpokePoolClient anymore. @amateima noted that you're still indexing older events, so I just wanted to check it off with you to confirm if/when this is OK to merge RE the indexer.

Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indexer should be good to go - this may be worth as a breaking version bump

@melisaguevara
Copy link
Contributor

@amateima @melisaguevara @james-a-morris This PR drops support for legacy V3 events, meaning they won't be able to be queried via the SpokePoolClient anymore. @amateima noted that you're still indexing older events, so I just wanted to check it off with you to confirm if/when this is OK to merge RE the indexer.

@james-a-morris @amateima I think we should wait until we finish the production backfilling to merge this. Do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants