Skip to content

epic: Solana v1 #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@ import { Preview } from "@storybook/react";
import { MemoryRouter } from "react-router-dom";

import { default as GlobalStyles } from "../src/components/GlobalStyles/GlobalStyles";
import { OnboardContext, useOnboardManager } from "../src/hooks/useOnboard";

const preview: Preview = {
decorators: [
(Story) => (
<MemoryRouter initialEntries={["/"]}>
<GlobalStyles />
<OnboardContext.Provider value={useOnboardManager()}>
<Story />
</OnboardContext.Provider>
<Story />
</MemoryRouter>
),
],
Expand Down
42 changes: 42 additions & 0 deletions api/_address.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import { Address, Hex, padHex, toBytes, toHex, trim } from "viem";
import { getAddressDecoder, getAddressEncoder } from "@solana/kit";
import { isAddress } from "ethers/lib/utils";
import { isAddress as isSvmAddress } from "@solana/kit"; // @solana/web3.js@v2

// exports
export { isSvmAddress };

// utils
export function isEvmAddress(value: string): value is Address {
return isAddress(value);
}

export function svmToHex(pubkey: string): Hex {
if (!isSvmAddress(pubkey)) {
throw new Error("Invalid SVM Address");
}
const bytes = getAddressEncoder().encode(pubkey);
return toHex(new Uint8Array(bytes));
}

export function hexToBase58(address: Address) {
if (!isEvmAddress(address)) {
throw new Error("Invalid EVM Address");
}
const bytes = trim(toBytes(address));
return getAddressDecoder().decode(bytes);
}

export function toBytes32(value: string) {
if (isSvmAddress(value)) {
// byte length already checked at this stage
return svmToHex(value);
}
if (isEvmAddress(value)) {
return padHex(value, {
size: 32,
dir: "left",
});
}
throw new Error("Invalid Address type. Must be valid EVM or SVM address");
}
26 changes: 22 additions & 4 deletions api/_utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {
size,
string,
Struct,
union,
} from "superstruct";
import enabledMainnetRoutesAsJson from "../src/data/routes_1_0xc186fA914353c44b2E33eBE05f21846F1048bEda.json";
import enabledSepoliaRoutesAsJson from "../src/data/routes_11155111_0x14224e63716afAcE30C9a417E0542281869f7d9e.json";
Expand Down Expand Up @@ -89,6 +90,7 @@ type LoggingUtility = sdk.relayFeeCalculator.Logger;
type RpcProviderName = keyof typeof rpcProvidersJson.providers.urls;

import { getEnvs } from "./_env";
import { isEvmAddress, isSvmAddress } from "./_address";

const {
REACT_APP_HUBPOOL_CHAINID,
Expand Down Expand Up @@ -1642,12 +1644,28 @@ export function parsableBigNumberString() {
});
}

export function validAddress() {
return define<string>("validAddress", (value) =>
utils.isAddress(value as string)
);
export function validEvmAddress() {
return define<string>("validEvmAddress", (value) => {
try {
return isEvmAddress(value as string);
} catch {
return false;
}
});
}

export function validSvmAddress() {
return define<string>("validSvmAddress", (value) => {
try {
return isSvmAddress(value as string);
} catch {
return false;
}
});
}

export const validAddress = () => union([validEvmAddress(), validSvmAddress()]);

export function validAddressOrENS() {
return define<string>("validAddressOrENS", (value) => {
const ensDomainRegex =
Expand Down
5 changes: 3 additions & 2 deletions e2e/wallet-setup/connected.setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ export default defineWalletSetup(MM_PASSWORD, async (context, walletPage) => {
// Go to a locally hosted MetaMask Test Dapp.
await page.goto(E2E_DAPP_URL);

// Connect via web3-onboard modal
// Connect via wallet
await page
.getByRole("banner")
.locator(page.getByRole("button", { name: "Connect" }))
.click();
await page.getByRole("button", { name: "MetaMask" }).click();

await page.getByText("MetaMask").first().click();

await metamask.connectToDapp(["Account 1"]);
});
17 changes: 8 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"@across-protocol/sdk": "^4.1.44",
"@amplitude/analytics-browser": "^2.3.5",
"@balancer-labs/sdk": "1.1.6-beta.16",
"@coral-xyz/borsh": "^0.30.1",
"@emotion/react": "^11.13.0",
"@emotion/styled": "^11.14.0",
"@fortawesome/fontawesome-svg-core": "^6.1.1",
Expand All @@ -19,21 +20,18 @@
"@safe-global/safe-apps-provider": "^0.18.0",
"@safe-global/safe-apps-sdk": "^8.1.0",
"@sentry/react": "^7.37.2",
"@solana/wallet-adapter-base": "^0.9.23",
"@solana/wallet-adapter-react": "^0.15.35",
"@solana/wallet-adapter-wallets": "^0.19.32",
"@solana/web3.js": "^1.98.0",
"@solana/kit": "^2.1.0",
"@tanstack/react-query": "v5",
"@tanstack/react-query-devtools": "v5",
"@uniswap/sdk-core": "^5.9.0",
"@uniswap/smart-order-router": "^4.7.8",
"@uniswap/v3-sdk": "^3.18.1",
"@upstash/qstash": "^2.7.20",
"@vercel/kv": "^2.0.0",
"@web3-onboard/coinbase": "^2.4.1",
"@web3-onboard/core": "^2.24.0",
"@web3-onboard/gnosis": "^2.2.0",
"@web3-onboard/injected-wallets": "^2.11.1",
"@web3-onboard/metamask": "^2.2.0",
"@web3-onboard/phantom": "^2.1.1",
"@web3-onboard/react": "^2.11.0",
"@web3-onboard/walletconnect": "^2.4.6",
"axios": "^0.27.2",
"ethers": "5.7.2",
"framer-motion": "^11.3.19",
Expand All @@ -44,7 +42,7 @@
"react": "v18",
"react-dom": "v18",
"react-feather": "^2.0.9",
"react-pro-sidebar": "^1.1.0-alpha.1",
"react-pro-sidebar": "^1.1.0",
"react-router-dom": "v5",
"react-tooltip": "^5.18.0",
"superstruct": "^0.15.4",
Expand Down Expand Up @@ -139,6 +137,7 @@
"@vercel/node": "^5.0.2",
"@vitejs/plugin-react": "^4.3.4",
"axios-mock-adapter": "^1.21.2",
"buffer": "^6.0.3",
"chalk": "^5.3.0",
"chromatic": "^11.25.1",
"dotenv": "^16.4.5",
Expand Down
1 change: 1 addition & 0 deletions scripts/chain-configs/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export { default as POLYGON_AMOY } from "./polygon-amoy";
export { default as REDSTONE } from "./redstone";
export { default as SCROLL } from "./scroll";
export { default as SEPOLIA } from "./sepolia";
export { default as SOLANA_DEVNET } from "./solana-devnet";
export { default as SONEIUM } from "./soneium";
export { default as TATARA } from "./tatara";
export { default as UNICHAIN } from "./unichain";
Expand Down
23 changes: 23 additions & 0 deletions scripts/chain-configs/solana-devnet/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { CHAIN_IDs, PUBLIC_NETWORKS } from "@across-protocol/constants";
import { utils as sdkUtils } from "@across-protocol/sdk";
import { ChainConfig } from "../types";

const { getDeployedAddress, getDeployedBlockNumber } = sdkUtils;

const chainId = CHAIN_IDs.SOLANA_DEVNET;
const chainInfoBase = PUBLIC_NETWORKS[chainId];

export default {
...chainInfoBase,
logoPath: "./assets/logo.svg",
grayscaleLogoPath: "./assets/grayscale-logo.svg",
spokePool: {
address: getDeployedAddress("SvmSpoke", chainId),
blockNumber: getDeployedBlockNumber("SvmSpoke", chainId),
},
chainId,
publicRpcUrl: "https://api.devnet.solana.com",
blockTimeSeconds: 0.5,
tokens: ["USDC"],
enableCCTP: true,
} as ChainConfig;
55 changes: 40 additions & 15 deletions scripts/generate-routes.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,38 @@
import { CHAIN_IDs, TOKEN_SYMBOLS_MAP } from "@across-protocol/constants";
import { utils as sdkUtils } from "@across-protocol/sdk";

import { utils } from "ethers";
import { writeFileSync } from "fs";
import { getAddress, isAddress as isEvmAddress } from "viem";
import { utils as sdkUtils } from "@across-protocol/sdk";
import { isAddress as isSvmAddress } from "@solana/kit";
import * as prettier from "prettier";
import path from "path";
import * as chainConfigs from "./chain-configs";
import * as externConfigs from "./extern-configs";
import assert from "assert";

// TODO: replace with Address utilities from sdk
export function checksumAddress(address: string) {
if (isEvmAddress(address)) {
return getAddress(address);
}
if (isSvmAddress(address)) {
return address;
}
throw new Error("Invalid address");
}

export const nonEthChains = [
CHAIN_IDs.POLYGON,
CHAIN_IDs.POLYGON_AMOY,
CHAIN_IDs.ALEPH_ZERO,
CHAIN_IDs.LENS_SEPOLIA,
CHAIN_IDs.SOLANA_DEVNET,
CHAIN_IDs.SOLANA,
];

export function isNonEthChain(chainId: number): boolean {
return nonEthChains.includes(chainId);
}

function getTokenSymbolForLogo(tokenSymbol: string): string {
switch (tokenSymbol) {
case "USDC.e":
Expand Down Expand Up @@ -66,6 +90,7 @@ export const enabledSepoliaChainConfigs = [
chainConfigs.LISK_SEPOLIA,
chainConfigs.LENS_SEPOLIA,
chainConfigs.UNICHAIN_SEPOLIA,
chainConfigs.SOLANA_DEVNET,
chainConfigs.TATARA,
];

Expand Down Expand Up @@ -499,15 +524,15 @@ async function generateRoutes(hubPoolChainId = 1) {

const routeFileContent = {
hubPoolChain: config.hubPoolChain,
hubPoolAddress: utils.getAddress(config.hubPoolAddress),
hubPoolWethAddress: utils.getAddress(config.hubPoolWethAddress),
acrossConfigStoreAddress: utils.getAddress(config.acrossConfigStoreAddress),
acrossTokenAddress: utils.getAddress(config.acrossTokenAddress),
acceleratingDistributorAddress: utils.getAddress(
hubPoolAddress: checksumAddress(config.hubPoolAddress),
hubPoolWethAddress: checksumAddress(config.hubPoolWethAddress),
acrossConfigStoreAddress: checksumAddress(config.acrossConfigStoreAddress),
acrossTokenAddress: checksumAddress(config.acrossTokenAddress),
acceleratingDistributorAddress: checksumAddress(
config.acceleratingDistributorAddress
),
merkleDistributorAddress: utils.getAddress(config.merkleDistributorAddress),
claimAndStakeAddress: utils.getAddress(config.claimAndStakeAddress),
merkleDistributorAddress: checksumAddress(config.merkleDistributorAddress),
claimAndStakeAddress: checksumAddress(config.claimAndStakeAddress),
swapAndBridgeAddresses: checksumAddressesOfNestedMap(
config.swapAndBridgeAddresses as Record<string, Record<string, string>>
),
Expand Down Expand Up @@ -560,7 +585,7 @@ async function generateRoutes(hubPoolChainId = 1) {
const tokenInfo =
TOKEN_SYMBOLS_MAP[tokenSymbol as keyof typeof TOKEN_SYMBOLS_MAP];
return {
address: utils.getAddress(
address: checksumAddress(
tokenInfo.addresses[chainConfig.chainId] as string
),
symbol: tokenSymbol,
Expand Down Expand Up @@ -715,7 +740,7 @@ function transformToRoute(
toChain: toChain.chainId,
fromTokenAddress: inputToken.address,
toTokenAddress: outputToken.address,
fromSpokeAddress: utils.getAddress(route.fromSpokeAddress),
fromSpokeAddress: checksumAddress(route.fromSpokeAddress),
fromTokenSymbol: inputTokenSymbol,
toTokenSymbol: outputTokenSymbol,
isNative,
Expand Down Expand Up @@ -752,9 +777,9 @@ function getTokenBySymbol(

return {
chainId,
address: utils.getAddress(tokenAddress),
address: checksumAddress(tokenAddress),
symbol: tokenSymbol,
l1TokenAddress: utils.getAddress(l1TokenAddress),
l1TokenAddress: checksumAddress(l1TokenAddress),
};
}

Expand Down Expand Up @@ -798,7 +823,7 @@ function getBridgedUsdcSymbol(chainId: number) {

function checksumAddressOfMap(map: Record<string, string>) {
return Object.entries(map).reduce(
(acc, [key, value]) => ({ ...acc, [key]: utils.getAddress(value) }),
(acc, [key, value]) => ({ ...acc, [key]: checksumAddress(value) }),
{}
);
}
Expand Down
13 changes: 2 additions & 11 deletions src/Routes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ const warningMessage = `
`;

function useRoutes() {
const [openSidebar, setOpenSidebar] = useState(false);
const [enableACXBanner, setEnableACXBanner] = useState(true);
const { provider, isContractAddress } = useConnection();
const location = useLocation();
Expand All @@ -82,8 +81,6 @@ function useRoutes() {
}, [location.pathname, history]);

return {
openSidebar,
setOpenSidebar,
provider,
error,
removeError,
Expand All @@ -99,8 +96,6 @@ function useRoutes() {
// Need this component for useLocation hook
const Routes: React.FC = () => {
const {
openSidebar,
setOpenSidebar,
error,
removeError,
location,
Expand Down Expand Up @@ -140,12 +135,8 @@ const Routes: React.FC = () => {
{isContractAddress && (
<SuperHeader size="lg">{warningMessage}</SuperHeader>
)}
<Header
openSidebar={openSidebar}
setOpenSidebar={setOpenSidebar}
transparentHeader={isAirdrop || isHomepage}
/>
<Sidebar openSidebar={openSidebar} setOpenSidebar={setOpenSidebar} />
<Header transparentHeader={isAirdrop || isHomepage} />
<Sidebar />
<ScrollToTop />
<Suspense fallback={<BouncingDotsLoader />}>
<Switch>
Expand Down
4 changes: 2 additions & 2 deletions src/assets/icons/arrow-up-right.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/assets/icons/logout.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions src/assets/wallet-logos/coinbase.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/assets/wallet-logos/injected.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading