chore: Deploy Lens SpokePool & Adapter #978
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Deploy Linea Adapter and SpokePool with CCTP V2 support - TODO: Deploy SpokePool * Add LineaSpokePool deployment
* improve: query shared bridge address dynamically Signed-off-by: bennett <[email protected]> * refactor --------- Signed-off-by: bennett <[email protected]> Co-authored-by: nicholaspai <[email protected]>
* feat: Support Lens Circle bridged USDC in SpokePool * immutable * Add zkSync contract gap * Centralise defs * Migrate to zkSync SpokePool * Update * update * Update contracts/ZkSync_SpokePool.sol * revert unnecessary change * Update comments * Fix deployment script * Simplify * Update comments * Update import * fixes * improve: support upgradeable USDC in zkstack adapters (#940) * improve: support upgradeable USDC in zkstack adapters Signed-off-by: bennett <[email protected]> * update deploy scripts Signed-off-by: bennett <[email protected]> * conform to CCTPAdapterInterface Signed-off-by: bennett <[email protected]> --------- Signed-off-by: bennett <[email protected]> * Update initial test * Update zkSync SpokePool storage * Extra test Signed-off-by: Paul <[email protected]> * Update test/evm/hardhat/chain-specific-spokepools/ZkSync_SpokePool.ts * Apply suggestions from code review * Harden constructor * Expand & fix * fix * Apply suggestions from code review * Add constructor checks to Adapters, update deploy script * Update 059_deploy_lens_spokepool.ts * Update contracts/ZkSync_SpokePool.sol Co-authored-by: Matt Rice <[email protected]> * Clarify constructor arguments for zkSync * readability in adapters * Update deploy/059_deploy_lens_spokepool.ts Co-authored-by: Matt Rice <[email protected]> * Move asserts * Remove if (address(_l2Usdc) != zero) * Fix deploy assert * Revert "Remove if (address(_l2Usdc) != zero)" This reverts commit ffeaade. * Rename constructor param * Remove SHARED_BRIDGE --------- Signed-off-by: bennett <[email protected]> Signed-off-by: Paul <[email protected]> Co-authored-by: bmzig <[email protected]> Co-authored-by: nicholaspai <[email protected]> Co-authored-by: nicholaspai <[email protected]> Co-authored-by: Matt Rice <[email protected]>
An approval is required to initiate a withdrawal of Circle bridged (upgradable) USDC on Lens.
nicholaspai
previously approved these changes
Apr 28, 2025
Signed-off-by: bennett <[email protected]>
…USDC Through CCTP (#976) Signed-off-by: bennett <[email protected]>
bmzig
previously approved these changes
Apr 28, 2025
pxrl
commented
Apr 28, 2025
bmzig
previously approved these changes
Apr 29, 2025
This variable is no longer used. Removing it addresses a warning being emitted by solc.
nicholaspai
previously approved these changes
Apr 30, 2025
pxrl
dismissed stale reviews from nicholaspai and bmzig
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.