-
Notifications
You must be signed in to change notification settings - Fork 0
staging -> production #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of `selectize` is pulling in vulnerable versions of `minimist` - technically the version we're on is what is required by the administrate gem but the API hasn't seemed to have changed significantly and I'm also pretty sure we don't render any administrate select fields, so we should be fine to ship this. Addresses GHSA-vh95-rmgr-6w4m Addresses GHSA-xvch-5gv4-984h
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.9 to 3.1.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mafintosh/tar-fs/commit/0aa57de79eb58a5206992c979a7fd5c4df85e07c"><code>0aa57de</code></a> 3.1.1</li> <li><a href="https://github.com/mafintosh/tar-fs/commit/0bd54cdf06da2b7b5b95cd4b062c9f4e0a8c4e09"><code>0bd54cd</code></a> expand check</li> <li><a href="https://github.com/mafintosh/tar-fs/commit/cb1c571fba8ec6dd56340f55dcd5d284372a8249"><code>cb1c571</code></a> 3.1.0</li> <li><a href="https://github.com/mafintosh/tar-fs/commit/374460e9973a5ac5655b7f21a84dfa9b64da5d78"><code>374460e</code></a> add optional disablement of symlink validation (<a href="https://redirect.github.com/mafintosh/tar-fs/issues/119">#119</a>)</li> <li><a href="https://github.com/mafintosh/tar-fs/commit/5bfe6dfb9d26436829ec6a6400eca3a030d4757a"><code>5bfe6df</code></a> 3.0.10</li> <li><a href="https://github.com/mafintosh/tar-fs/commit/63e12f94740afa9ba87f91c1a530ad91548ba3a9"><code>63e12f9</code></a> bare support</li> <li>See full diff in <a href="https://github.com/mafintosh/tar-fs/compare/v3.0.9...v3.1.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/ackama/nzsl-share/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The main change I had to do was with the `upload-start`(ed) event, which now expects to be called with the full list of files and thus is not appropriate to call within the uploading of each individual file. While the end fix seems to be straightforward, it was made a lot harder to track down by the fact we were settling the promises meaning the error that got thrown after just blindly switching to `upload-start` without moving the calls was silently eaten, and then the postprocesser would error instead since it assumes the upload(s) were successful. To make it easier to catch, I've switched us to using `Promise.all` which will reject if any of the promises reject, and that seems to be handled properly by Uppy (i.e. it does not call the postprocessor). I have also updated the import of `EventTracker` to be `EventManager` because it will be moved to `@uppy/core` in v5 with the new name only. Addresses GHSA-mwcw-c2x4-8c55
These specs currently fail semi-frequently since there is no actual guarantee that the emails will be in the same order every time, so I've rewritten the tests to select all emails with the expected `to` address
Bumps [rack](https://github.com/rack/rack) from 2.2.14 to 2.2.18. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rack/rack/blob/main/CHANGELOG.md">rack's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file. For info on how to format all future additions to this file please reference <a href="https://keepachangelog.com/en/1.0.0/">Keep A Changelog</a>.</p> <h2>Unreleased</h2> <h3>SPEC Changes</h3> <ul> <li>Define <code>rack.response_finished</code> callback arguments more strictly. (<a href="https://redirect.github.com/rack/rack/pull/2365">#2365</a>, <a href="https://github.com/skipkayhil"><code>@skipkayhil</code></a>)</li> </ul> <h3>Added</h3> <ul> <li>Add <code>Rack::Files#assign_headers</code> to allow overriding how the configured file headers are set. (<a href="https://redirect.github.com/rack/rack/pull/2377">#2377</a>, <a href="https://github.com/codergeek121"><code>@codergeek121</code></a>)</li> <li>Add support for <code>rack.response_finished</code> to <code>Rack::TempfileReaper</code>. (<a href="https://redirect.github.com/rack/rack/pull/2363">#2363</a>, <a href="https://github.com/skipkayhil"><code>@skipkayhil</code></a>)</li> <li>Add support for streaming bodies when using <code>Rack::Events</code>. (<a href="https://redirect.github.com/rack/rack/blob/main/redirect.github.com/rack/rack/pull/2375">#2375</a>, <a href="https://github.com/unflxw"><code>@unflxw</code></a>)</li> </ul> <h3>Changed</h3> <ul> <li>Raise before exceeding a part limit, not after. (<a href="https://redirect.github.com/rack/rack/pull/2362">#2362</a>, <a href="https://github.com/matthew-puku"><code>@matthew-puku</code></a>)</li> <li>Rack::Deflater now uses a fixed GZip mtime value. (<a href="https://redirect.github.com/rack/rack/pull/2372">#2372</a>, <a href="https://github.com/bensheldon"><code>@bensheldon</code></a>)</li> </ul> <h3>Fixed</h3> <ul> <li>Fix an issue where a <code>NoMethodError</code> would be raised when using <code>Rack::Events</code> with streaming bodies. (<a href="https://redirect.github.com/rack/rack/blob/main/redirect.github.com/rack/rack/pull/2375">#2375</a>, <a href="https://github.com/unflxw"><code>@unflxw</code></a>)</li> </ul> <h2>[3.2.0] - 2025-07-31</h2> <p>This release continues Rack's evolution toward a cleaner, more efficient foundation while maintaining backward compatibility for most applications. The breaking changes primarily affect deprecated functionality, so most users should experience a smooth upgrade with improved performance and standards compliance.</p> <h3>SPEC Changes</h3> <ul> <li>Request environment keys must now be strings. (<a href="https://redirect.github.com/rack/rack/issues/2310">#2310</a>, [<a href="https://github.com/jeremyevans"><code>@jeremyevans</code></a>])</li> <li>Add <code>nil</code> as a valid return from a Response <code>body.to_path</code> (<a href="https://redirect.github.com/rack/rack/pull/2318">#2318</a>, [<a href="https://github.com/MSP-Greg"><code>@MSP-Greg</code></a>])</li> <li><code>Rack::Lint#check_header_value</code> is relaxed, only disallowing CR/LF/NUL characters. (<a href="https://redirect.github.com/rack/rack/pull/2354">#2354</a>, [<a href="https://github.com/ioquatix"><code>@ioquatix</code></a>])</li> </ul> <h3>Added</h3> <ul> <li>Introduce <code>Rack::VERSION</code> constant. (<a href="https://redirect.github.com/rack/rack/pull/2199">#2199</a>, [<a href="https://github.com/ioquatix"><code>@ioquatix</code></a>])</li> <li><code>ISO-2022-JP</code> encoded parts within MIME Multipart sections of an HTTP request body will now be converted to <code>UTF-8</code>. (<a href="https://redirect.github.com/rack/rack/pull/2245">#2245</a>, <a href="https://github.com/nappa"><code>@nappa</code></a>)</li> <li>Add <code>Rack::Request#query_parser=</code> to allow setting the query parser to use. (<a href="https://redirect.github.com/rack/rack/pull/2349">#2349</a>, [<a href="https://github.com/jeremyevans"><code>@jeremyevans</code></a>])</li> <li>Add <code>Rack::Request#form_pairs</code> to access form data as raw key-value pairs, preserving duplicate keys. (<a href="https://redirect.github.com/rack/rack/pull/2351">#2351</a>, [<a href="https://github.com/matthewd"><code>@matthewd</code></a>])</li> </ul> <h3>Changed</h3> <ul> <li>Invalid cookie keys will now raise an error. (<a href="https://redirect.github.com/rack/rack/pull/2193">#2193</a>, [<a href="https://github.com/ioquatix"><code>@ioquatix</code></a>])</li> <li><code>Rack::MediaType#params</code> now handles empty strings. (<a href="https://redirect.github.com/rack/rack/pull/2229">#2229</a>, [<a href="https://github.com/jeremyevans"><code>@jeremyevans</code></a>])</li> <li>Avoid unnecessary calls to the <code>ip_filter</code> lambda to evaluate <code>Request#ip</code> (<a href="https://redirect.github.com/rack/rack/pull/2287">#2287</a>, [<a href="https://github.com/willbryant"><code>@willbryant</code></a>])</li> <li>Only calculate <code>Request#ip</code> once per request (<a href="https://redirect.github.com/rack/rack/pull/2292">#2292</a>, [<a href="https://github.com/willbryant"><code>@willbryant</code></a>])</li> <li><code>Rack::Builder</code> <code>#use</code>, <code>#map</code>, and <code>#run</code> methods now return <code>nil</code>. (<a href="https://redirect.github.com/rack/rack/pull/2355">#2355</a>, [<a href="https://github.com/ioquatix"><code>@ioquatix</code></a>])</li> <li>Directly close the body in <code>Rack::ConditionalGet</code> when the response is <code>304 Not Modified</code>. (<a href="https://redirect.github.com/rack/rack/pull/2353">#2353</a>, [<a href="https://github.com/ioquatix"><code>@ioquatix</code></a>])</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rack/rack/commit/0f76d43c0d5624bd0d325df4f0a63f5e1faa7254"><code>0f76d43</code></a> Bump patch version.</li> <li><a href="https://github.com/rack/rack/commit/493a4119ea010a7ac3dbc0ff579fc8af42e24ba4"><code>493a411</code></a> Fix thin integration.</li> <li><a href="https://github.com/rack/rack/commit/54e4ffdd5affebcb0c015cc6ae74635c0831ed71"><code>54e4ffd</code></a> Unbounded parameter parsing in <code>Rack::QueryParser</code>.</li> <li><a href="https://github.com/rack/rack/commit/9163ac3f5fac795179f9935e2ba6533a0ca1cf82"><code>9163ac3</code></a> Bump patch version.</li> <li><a href="https://github.com/rack/rack/commit/8e52d2a3769e83fc698784b06c82703ba40448e7"><code>8e52d2a</code></a> Backport <a href="https://redirect.github.com/rack/rack/issues/2263">#2263</a> to v2.2, fix: malformed charset param (<a href="https://redirect.github.com/rack/rack/issues/2338">#2338</a>)</li> <li><a href="https://github.com/rack/rack/commit/2a32ecaaa8460a9af9963ee46ba04afbd1b47220"><code>2a32eca</code></a> Bump patch version.</li> <li><a href="https://github.com/rack/rack/commit/034a13c80dc639c8a4e794f425e5e9e17ede856b"><code>034a13c</code></a> Change CGI::Cookie.new to Cookie.new (<a href="https://redirect.github.com/rack/rack/issues/2335">#2335</a>)</li> <li><a href="https://github.com/rack/rack/commit/d2b6af2062a4687f928491f801984b948a63ecbb"><code>d2b6af2</code></a> Bump patch version.</li> <li><a href="https://github.com/rack/rack/commit/f34f2ebfc8e5f5019a6aca6fccf427b4f0aadeff"><code>f34f2eb</code></a> Feature detect <code>CGI::Cookie</code>. (<a href="https://redirect.github.com/rack/rack/issues/2333">#2333</a>)</li> <li><a href="https://github.com/rack/rack/commit/2f928b9f141d848b81ca464d0c6fe3dc57469c38"><code>2f928b9</code></a> Replace usage of CGI::Cookie (<a href="https://redirect.github.com/rack/rack/issues/2329">#2329</a>)</li> <li>Additional commits viewable in <a href="https://github.com/rack/rack/compare/v2.2.14...v2.2.18">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/ackama/nzsl-share/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nzlaura
approved these changes
Sep 25, 2025
This makes things a bit easier to read on mobile without (hopefully) impacting the rest of the structure Before: <img width="528" height="978" alt="image" src="https://github.com/user-attachments/assets/b38bdaa0-ceff-4cf9-a3f3-0a1d25e779a1" /> After: <img width="538" height="970" alt="image" src="https://github.com/user-attachments/assets/4f74042a-56c3-4f87-a2dd-aa6ca9782b3c" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.