Skip to content

fix: xcode properly registering extension folder & automatically apply dev team from main app#187

Merged
achorein merged 1 commit intoachorein:mainfrom
ChristopherGabba:main
Sep 4, 2025
Merged

fix: xcode properly registering extension folder & automatically apply dev team from main app#187
achorein merged 1 commit intoachorein:mainfrom
ChristopherGabba:main

Conversation

@ChristopherGabba
Copy link
Contributor

@ChristopherGabba ChristopherGabba commented Aug 9, 2025

Summary

Good morning @achorein,

I noticed your expo config plugin did work correctly, but when you opened the extension, it would not properly create a group in Xcode. The files would be under "Recovered References".

Before:

Screenshot 2025-08-09 at 6 51 20 AM

After PR:

Screenshot 2025-08-09 at 7 19 29 AM

I also did a small "nice-to-do" feature where when you run the config plugin, it checks the main app for a Development Team in ios and copies that over to the extension. This should resolve a couple of your issues:

#154
#183

I did this in my plugin for a package I built and its nice, I don't necessarily rely on Expo to copy over the dev team. I don't think anyone uses a different development team for the Extension than they would for their main app.

Please feel free to try it out before merging, but I think you'll like it.

@rborn
Copy link

rborn commented Aug 11, 2025

I tested this PR and it works fine ( I could not make it work without it)
One thing to note - I had to delete and regenerate the profile in apple's developer account ( didn't try before the PR so it might be related)
@ChristopherGabba great work 🙏

@xpluscal
Copy link

Soooo, can we merge this? :))

@xpluscal
Copy link

Until this is merged is there some other workaround?

@achorein
Copy link
Owner

achorein commented Sep 2, 2025

Thanks for the PR, I will check this today or tomorow

@achorein achorein merged commit e1a53e3 into achorein:main Sep 4, 2025
4 checks passed
@achorein
Copy link
Owner

achorein commented Sep 4, 2025

released in v4.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants