fix: xcode properly registering extension folder & automatically apply dev team from main app#187
Merged
achorein merged 1 commit intoachorein:mainfrom Sep 4, 2025
ChristopherGabba:main
Merged
fix: xcode properly registering extension folder & automatically apply dev team from main app#187achorein merged 1 commit intoachorein:mainfrom ChristopherGabba:main
achorein merged 1 commit intoachorein:mainfrom
ChristopherGabba:main
Conversation
|
I tested this PR and it works fine ( I could not make it work without it) |
|
Soooo, can we merge this? :)) |
|
Until this is merged is there some other workaround? |
Owner
|
Thanks for the PR, I will check this today or tomorow |
Owner
|
released in v4.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Good morning @achorein,
I noticed your expo config plugin did work correctly, but when you opened the extension, it would not properly create a group in Xcode. The files would be under "Recovered References".
Before:
After PR:
I also did a small "nice-to-do" feature where when you run the config plugin, it checks the main app for a Development Team in ios and copies that over to the extension. This should resolve a couple of your issues:
#154
#183
I did this in my plugin for a package I built and its nice, I don't necessarily rely on Expo to copy over the dev team. I don't think anyone uses a different development team for the Extension than they would for their main app.
Please feel free to try it out before merging, but I think you'll like it.