Add admin option to enable/disable compression when archiving tasks #1123 #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectories (refactor keyword args to positional) aces#1123
MontrealSergiy
added
the
Admin
prioux
reviewed
Jan 21, 2025
| @@ -707,12 +708,14 @@ def operation | |||
| archive_dp_id = params[:archive_dp_id].presence # for 'archive as file' operation | |||
| dup_bourreau_id = nil unless dup_bourreau_id && Bourreau.find_all_accessible_by_user(current_user).where(:id => dup_bourreau_id).exists? | |||
| archive_dp_id = nil unless archive_dp_id && DataProvider.find_all_accessible_by_user(current_user).where(:id => archive_dp_id).exists? | |||
| nozip = params[:nozip].presence && current_user.has_role?(:admin_user) # for archiving without compression, admin only | |||
There was a problem hiding this comment.
use .present? not .presence, they're not the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a no-compression checkbox is added to the Archive panel in the task list
see #1123 for details