Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove time_of_death attribute from Data Provider #1381

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Remove time_of_death attribute from Data Provider #1381

merged 2 commits into from
Mar 6, 2024

Conversation

MontrealSergiy
Copy link
Contributor

see #1373

@MontrealSergiy MontrealSergiy linked an issue Feb 27, 2024 that may be closed by this pull request
The attribute time_of_death is no longer used in DataProvider model. #1373
Closed
@MontrealSergiy MontrealSergiy added Admin Features or bugs related to administrative features Priority: Low To implement when someone actually requests it! labels Feb 27, 2024
@MontrealSergiy MontrealSergiy changed the base branch from master to dev February 27, 2024 18:39
@prioux
Copy link
Member

prioux commented Feb 29, 2024

You schema update changes the collation character set for the tables, please don't do that. Ensure that your DB is using the proper collation keywords before you run your migration so that it doesnt' change (You'll probably have to update manually your tables with a alter table command in your SQL client)

prioux
prioux requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collation are changed and they shouldn't.

@MontrealSergiy MontrealSergiy changed the base branch from dev to master February 29, 2024 19:26
@MontrealSergiy MontrealSergiy changed the base branch from master to dev February 29, 2024 19:27
@MontrealSergiy
Copy link
Contributor Author

the collation is corrected

@prioux
Copy link
Member

prioux commented Mar 6, 2024

This PR is fine.

@prioux prioux changed the base branch from dev to master March 6, 2024 16:11
@prioux prioux merged commit 4e593c4 into aces:master Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prioux prioux prioux requested changes

Assignees

@MontrealSergiy MontrealSergiy

Labels
Admin Features or bugs related to administrative features Priority: Low To implement when someone actually requests it! Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The attribute time_of_death is no longer used in DataProvider model.
3 participants
@MontrealSergiy @prioux @natacha-beck