-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull 26.0.1 and 26.0.2 bug fixes into main #1233
Conversation
Regarding the CI failures:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR ! Small things I found while reading the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review take two.
Will test and fix the static errors soon! Blocked. |
c9e4d19
to
af59df9
Compare
I left it in script because delete_physiological_file is a script, not a lib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I added a commit to set the new script as executable:
git update-index --chmod=+x python/scripts/delete_physiological_file.py
The new script works on my machine (although not sure if we really want to print the paths as {FilePath: '...'}
) !
(loris-mri-python) lorisadmin@loris:/opt/loris/bin/mri$ delete_physiological_file.py --fileid 1 --profile database_config.py --confirm --deleteondisk
Archives
----------------------------
({'FilePath': 'bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_eeg.tgz'},)
Physiological File
----------------------------
({'FilePath': 'bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_eeg.edf'},)
Physiological Metadata File
----------------------------
()
Channels
----------------------------
({'FilePath': 'bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_channels.tsv'},)
Electrodes
----------------------------
({'FilePath': 'bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_electrodes.tsv'},)
Coordinate Systems
----------------------------
()
Event Files
----------------------------
({'FilePath': 'bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_events.tsv'},)
Event Archives
----------------------------
()
Chunks
----------------------------
({'FilePath': 'bids_imports/Face13_BIDSVersion_1.1.0_chunks/sub-OTT167_ses-V1_task-faceO_eeg.chunks'},)
Dropping all DB entries for physiological file: 1
----------------------------
Delete physiological_event_parameter_category_level
Delete physiological_event_parameter
Delete physiological_channel
Delete physiological_electrode
Delete physiological_coord_system_point_3d_rel
Delete point_3d
Delete physiological_coord_system
Delete physiological_coord_system_electrode_rel
Delete physiological_electrode
Delete physiological_parameter_file
Delete physiological_archive
Delete physiological_event_archive
Delete physiological_task_event_opt
Delete physiological_task_event_hed_rel
Delete physiological_task_event
Delete physiological_event_file
Delete physiological_file
Deleting files on disk for physiological file: 1
----------------------------
Deleting file bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_eeg.tgz
Deleting file bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_eeg.edf
Deleting file bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_channels.tsv
Deleting file bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_electrodes.tsv
Deleting file bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_events.tsv
Replace #1225