Migrate ImagingUpload and MriUploadDB to the new database abstraction
#1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
changed the title
ImagingUpload and MriUploadDB to sqlalchemyImagingUpload and MriUploadDB to the new database abstraction
maximemulder
force-pushed
the
sqlalchemy_mri_upload
branch
4 times, most recently
from
2b5499e to
c26a276
Compare
maximemulder
force-pushed
the
sqlalchemy_mri_upload
branch
from
169b543 to
352e8be
Compare
maximemulder
added
Area: BIDS
cmadjar
reviewed
Feb 14, 2025
There was a problem hiding this comment.
@maximemulder very nice!! A few minor suggestions/questions. I did not test it yet.
use dicom archive id instead of tarchiveid because it is prettier ruff check
maximemulder
force-pushed
the
sqlalchemy_mri_upload
branch
from
8eed0e7 to
eca3d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
ImagingUploadandMriUploadDBto the new database abstraction.The current input checking is very complex and this should simplify it a little. The previous code seems to sometimes accept or forget to check if the DICOM archive or MRI upload is null in a few specific places, but I do not see how it can work as a whole in these conditions. I therefore assume the DICOM archive and MRI upload must not be null.
The integration test will check if this works broadly, but since this touches the argument validation, I will need to test the pipeline manually with:
Tested and there does not seem to be any regression:
run_dicom_archive_loader.pyexpects either (exclusive)--upload_idor--tarchive_path, and requires the DICOM archive to be associated with exactly one MRI upload.