Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Support for throttleProp #185

Closed
wants to merge 2 commits into from
Closed

Support for throttleProp #185

wants to merge 2 commits into from

Conversation

wuct
Copy link
Contributor

@wuct wuct commented May 29, 2016

Please see #168 for more detail


wrapper.setProps({ throttled: 1 })

wrapper.instance().xforms[0].destroy()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is a good idea to introduce xforms here, because xforms is designed for internal use in createHocFromMiddleware and might be changed in the future.
However, it is just a quick hack and advices are welcome.

@acdlite
Copy link
Owner

acdlite commented May 30, 2016

Cool! (Heads up, I probably won't be able to review this until next week when I get back from React Europe.)

@wuct
Copy link
Contributor Author

wuct commented May 31, 2016

@acdlite Good luck on your talk and workshop ;)
I wish I could be there.

@istarkov
Copy link
Contributor

@wuct having mapPropsStream do we need throttleProps?

@wuct
Copy link
Contributor Author

wuct commented Sep 12, 2016

@istarkov IMHO it still need time for Observable to get widely-adopted, so throttleProps might be still useful.

However, mapPropsStream can replace all other functions in the end.

@jschlieber
Copy link

When can we expect this feature to be released?

@wuct
Copy link
Contributor Author

wuct commented Dec 13, 2016

@jschlieber Because this PR is blocked by #182, the time is still uncertain.

@istarkov
Copy link
Contributor

Will close as corresponding or is also closed, and it looks to me that its always better to throttle handlers and not props as like as here https://github.com/deepsweet/hocs

@istarkov istarkov closed this Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants