Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

fix(sagas): correct clause spacing and parsing - NA #68

Merged
merged 3 commits into from
Jul 17, 2019

Conversation

jolanglinais
Copy link
Member

@jolanglinais jolanglinais commented Jul 17, 2019

Issue N/A

Implement temporary fix for both clauses having no spacing in between them and some clauses parsing incorrectly

Changes

  • Add a stock text line after each clause
  • Implement a roundTrip + rebuild grammar functionality for parsing whitespace correctly

Flags

  • These are temporary fixes for development
    • roundTrip should be handled in cicero-core, but awaiting resolution to this issue
    • markdown-editor may need tweaking for adding a space after a clause

Related Issues

@jolanglinais jolanglinais added the Type: Bug 🐛 Something isn't working label Jul 17, 2019
@jolanglinais jolanglinais self-assigned this Jul 17, 2019
@jolanglinais jolanglinais changed the title Jl multi clause parse fix(sagas): correct clause spacing and parsing - NA Jul 17, 2019
@jolanglinais jolanglinais merged commit 2f65bd5 into accordproject:master Jul 17, 2019
@jolanglinais jolanglinais deleted the jl-multi-clause-parse branch July 17, 2019 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants