Skip to content

sorry mike i love you #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sorry mike i love you #33

wants to merge 1 commit into from

Conversation

ddistant
Copy link

im so sorry please forgive me

cspickert
cspickert reviewed Aug 17, 2015
View reviewed changes
OptionSelector/OSCategoriesTableViewController.m
@interface OSCategoriesTableViewController () <UITableViewDelegate>

@property (nonatomic) NSArray *CQCategories;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Try to keep your vertical spacing consistent (there should be one empty line between the last @property and @end).

@cspickert
Copy link

Nice work overall. I think the biggest problem I'm seeing is that OSCategoriesTableViewController knows too much about the way OSStuffTableViewController is implemented. A good place to start reworking things would be to avoid having OSCategoriesTableViewController rely on the fact that OSStuffTableViewController uses a table view at all. That would force you to explore other ways of passing data between the two objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddistant @cspickert