fix(dubbing): preserve replacement audio past video length - #104
Open
nateEc wants to merge 1 commit into
Open
Conversation
- Add an opt-out for ffmpeg -shortest in audio replacement. - Keep existing shortest behavior as the helper default for non-dubbing callers. - Disable shortest for Gulliver and RVC dubbing outputs so long translated audio is not cut. - Verified with python3 -m py_compile on the touched Python modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ffmpeg -shortestinffmpeg_replace_audio.-shortestfor Gulliver and RVC dubbing videos so translated audio longer than the source video is preserved.Fixes #26.
Verification
python3 -m py_compile app/abus_ffmpeg.py app/gradio_gulliver.py app/gradio_rvc.py