-
Notifications
You must be signed in to change notification settings - Fork 43
Request method version missing #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
See https://github.com/ably/specification/blob/main/textile/features.textile, the method signature is `request(String method, String path, Int version, Dict<String, String> params?, JsonObject | JsonArray body?, Dict<String, String> headers?)`. This PR should not be merged, but should serve as the basis to check where else we refer to the request method with an incorrect signature. In addition, we should we which SDKs are 2.x and thus use this new signature.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
See https://github.com/ably/specification/blob/main/textile/features.textile, the method signature is
request(String method, String path, Int version, Dict<String, String> params?, JsonObject | JsonArray body?, Dict<String, String> headers?)
.This PR should not be merged, but should serve as the basis to check where else we refer to the request method with an incorrect signature.
In addition, we should we which SDKs are 2.x and thus use this new signature.