Chat add message.with event example #2477
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
vladvelici
force-pushed
the
chat-add-message.with-event-example
branch
from
99c2463 to
772270e
Compare
AndyTWF
reviewed
Mar 13, 2025
content/chat/rooms/messages.textile
Outdated
|
|
||
| Update and Delete events provide the full message payload, so may be used to replace the entire earlier version of the message. | ||
|
|
||
| h3(#keep-messages-updated). Keep messages updated with @with@ |
There was a problem hiding this comment.
Can we wrap this entire section in a blang until we have Kotlin/Swift equivalents?
There was a problem hiding this comment.
I can't seem to get this to work correctly.
content/chat/rooms/messages.textile
Outdated
|
|
||
| Update and Delete events provide the full message payload, so may be used to replace the entire earlier version of the message. | ||
|
|
||
| h3(#keep-messages-updated). Keep messages updated with @with@ |
There was a problem hiding this comment.
At the moment this is in the "ordering" section - feels like it should be part of message update?
content/chat/rooms/messages.textile
Outdated
| import { MessageEvents, Message } from '@ably/chat'; | ||
| let myMessageList: Message[]; | ||
|
|
||
| const {unsubscribe} = room.messages.subscribe((event) => { |
There was a problem hiding this comment.
Suggested change
| const {unsubscribe} = room.messages.subscribe((event) => { | |
| const { unsubscribe } = room.messages.subscribe((event) => { |
content/chat/rooms/messages.textile
Outdated
| break; | ||
| case MessageEvents.Updated: | ||
| case MessageEvents.Deleted: | ||
| const idx = myMessageList.findIndex((msg) => msg.serial === event.message.serial); |
There was a problem hiding this comment.
Suggested change
| const idx = myMessageList.findIndex((msg) => msg.serial === event.message.serial); | |
| const idx = myMessageList.findIndex((msg) => event.message.isNewerVersionOf(msg)); |
content/chat/rooms/messages.textile
Outdated
| case MessageEvents.Deleted: | ||
| setMyMessageList((prev) => { | ||
| // find existing message to apply update or delete to | ||
| const existing = prev.list.find(event.message); |
There was a problem hiding this comment.
Suggested change
| const existing = prev.list.find(event.message); | |
| const existing = prev.list.findIndex((msg) => event.message.isNewerVersionOf(msg)); |
|
Made this a draft, will pick it up after either Swift and Kotlin add the |
vladvelici
force-pushed
the
chat-add-message.with-event-example
branch
from
772270e to
0e22967
Compare
AndyTWF
force-pushed
the
integration/chat-js-0.5.0
branch
2 times, most recently
from
7e218a6 to
bc070bb
Compare
GregHolmes
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://ably.atlassian.net/browse/CHA-871
Checklist