Added A Title LOGO (ICON) #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a icon file for Title
Added Icon link of Font-awesome for the title.
|
Is FontAwesome being used anywhere? I think Material Icons are being used everywhere. |
|
I think Both are fine... Font awesome is most poplar than material icons, but the big thing is that both have same work , both give an icons and free to use , both come up with CDNs... I think that's fine if we use font awesome or material... |
|
@NeerajRegaltos I meant in this project 😅 We don't have use of FontAwesome in this project so adding cdn of it has no benefit and only would increase latency. |
|
yes i see , you didnt use font awesome anywhere in this project , you used material icons, thats also fine... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added the link of font awesome CDN and added Icon for title , Added file in the folder Its working fine also.. Hope you will merge it.